[DevTools] Fix links for JSFrame records in timeline

third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineJSProfile.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 
 WebInspector.TimelineJSProfileProcessor = { };
 
 /**
  * @param {!WebInspector.CPUProfileDataModel} jsProfileModel
  * @param {!WebInspector.TracingModel.Thread} thread
@@ skipping 15 matching lines @@
         if (!node) {
             console.error(`Node with unknown id ${samples[i]} at index ${i}`);
             continue;
         }
         if (node === gcNode || node === idleNode)
             continue;
         var callFrames = nodeToStackMap.get(node);
         if (!callFrames) {
             callFrames = /** @type {!Array<!RuntimeAgent.CallFrame>} */ (new Array(node.depth + 1));
             nodeToStackMap.set(node, callFrames);
-            for (var j = 0; node.parent; node = node.parent)
-                callFrames[j++] = /** @type {!RuntimeAgent.CallFrame} */ (node);
+            for (var j = 0; node.parent; node = node.parent) {
+                // Tracing Events are 1-based.
+                callFrames[j++] = /** @type {!RuntimeAgent.CallFrame} */ ({
+                    functionName: node.functionName,

[alph, 2016/07/15 22:42:25]

You're creating a bunch of objects here. There were just a few nodes per
profile, but you duplicating them for each sample. Moreover you are making
RuntimeAgent.CallFrame's with a 1-based numbers that breaks the contract. I
don't like this solution.

+                    scriptId: node.scriptId,
+                    url: node.url,
+                    lineNumber: node.lineNumber + 1,
+                    columnNumber: node.columnNumber + 1
+                });
+            }
         }
         var jsSampleEvent = new WebInspector.TracingModel.Event(WebInspector.TracingModel.DevToolsTimelineEventCategory,
             WebInspector.TimelineModel.RecordType.JSSample,
             WebInspector.TracingModel.Phase.Instant, timestamps[i], thread);
         jsSampleEvent.args["data"] = { stackTrace: callFrames };
         jsEvents.push(jsSampleEvent);
     }
     return jsEvents;
 }
 
@@ skipping 440 matching lines @@
                 WebInspector.TracingModel.Phase.Instant, e.startTime, e.thread);
             sampleEvent.ordinal = e.ordinal;
             sampleEvent.args = {"data": {"stackTrace": stack }};
             samples.push(sampleEvent);
             break;
         }
     }
 
     return samples;
 }