Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issue 2156503003: Have Ozone X11 directly create GLSurfaces. (Closed)

Created:
4 years, 5 months ago by kylechar
Modified:
4 years, 5 months ago
Reviewers:
no sievers
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@new_ozone_gl
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Have Ozone X11 directly create GLSurfaces. The Ozone X11 platform now directly creates an appropriate GLSurface instead of creating a SurfaceOzoneEGL. Remove the SurfaceOzoneEGL subclass and add a new GLSurface subclass. Modify gl_factory_ozone.cc to use the new Ozone surface creation API. For kGLImplementationOSMesaGL and kGLImplementationMockGL there is a default implementation that is shared by all Ozone platforms. For other GL implementations surface creation is delegated to the Ozone platform. Add an OWNERS file for ui/gl/init/ that contains the per-file directive for Ozone files from ui/gl/. This code was all moved from ui/gl/ since it reduced the set of OWNERS. Add myself to this set as well. BUG=611142 Committed: https://crrev.com/d6455ff601505aa6b111b087b3ee5af30a3cc385 Cr-Commit-Position: refs/heads/master@{#407485}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -84 lines) Patch
A + ui/gl/init/OWNERS View 1 chunk +1 line, -4 lines 0 comments Download
M ui/gl/init/gl_factory_ozone.cc View 2 chunks +94 lines, -35 lines 0 comments Download
M ui/ozone/platform/x11/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/platform/x11/x11_surface_factory.h View 2 chunks +8 lines, -2 lines 0 comments Download
M ui/ozone/platform/x11/x11_surface_factory.cc View 4 chunks +73 lines, -43 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (11 generated)
kylechar
4 years, 5 months ago (2016-07-15 17:33:15 UTC) #4
no sievers
lgtm
4 years, 5 months ago (2016-07-15 18:04:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2156503003/40001
4 years, 5 months ago (2016-07-25 14:51:40 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 5 months ago (2016-07-25 15:42:14 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 15:45:09 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d6455ff601505aa6b111b087b3ee5af30a3cc385
Cr-Commit-Position: refs/heads/master@{#407485}

Powered by Google App Engine
This is Rietveld 408576698