Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 2156483002: Shutdown PeerConnectionDependencyFactory before Blink shutdown (Closed)

Created:
4 years, 5 months ago by tzik
Modified:
3 years, 9 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Shutdown PeerConnectionDependencyFactory before Blink shutdown WebRTC stuff indirectly touches GCed Blink objects, that requires it to shutdown before Blink shutdown. BUG=627004

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -19 lines) Patch
M content/renderer/media/webrtc/peer_connection_dependency_factory.h View 4 chunks +3 lines, -9 lines 0 comments Download
M content/renderer/media/webrtc/peer_connection_dependency_factory.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (10 generated)
tzik
PTAL to: perkj: c/r/m/webrtc and overall, esprehn: c/r/render_thread_impl.cc
4 years, 5 months ago (2016-07-15 05:51:57 UTC) #8
hbos_chromium
lgtm
4 years, 5 months ago (2016-07-15 08:38:53 UTC) #12
perkj_chrome
4 years, 5 months ago (2016-07-15 10:29:06 UTC) #13
lgtm but please see the comments in the bug.

Powered by Google App Engine
This is Rietveld 408576698