Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2156463002: remove unused TableMaskFilter (Closed)

Created:
4 years, 5 months ago by reed1
Modified:
4 years, 5 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -213 lines) Patch
M gyp/effects.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
D include/effects/SkTableMaskFilter.h View 1 chunk +0 lines, -66 lines 0 comments Download
D src/effects/SkTableMaskFilter.cpp View 1 chunk +0 lines, -145 lines 0 comments Download

Messages

Total messages: 10 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2156463002/1
4 years, 5 months ago (2016-07-15 02:12:01 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/59779ae8ce316bf8b8082ec2df1683ccd38161f1
4 years, 5 months ago (2016-07-15 02:13:25 UTC) #9
jcgregorio
4 years, 5 months ago (2016-07-18 14:43:53 UTC) #10
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2156183002/ by jcgregorio@google.com.

The reason for reverting is: Needed for Android:

frameworks/base/core/jni/android/graphics/MaskFilter.cpp:5:10: fatal error:
'SkTableMaskFilter.h' file not found.

Powered by Google App Engine
This is Rietveld 408576698