Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: chrome/browser/resources/settings/privacy_page/privacy_page.js

Issue 2156413002: Settings Router Refactor: Migrate to settings.Route.navigateTo calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use timing fix Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/privacy_page/privacy_page.js
diff --git a/chrome/browser/resources/settings/privacy_page/privacy_page.js b/chrome/browser/resources/settings/privacy_page/privacy_page.js
index f774ec9a32106b31e7f282726f6bb0aad026b052..bc357a3f449716a8868ba5061d372076386a86a3 100644
--- a/chrome/browser/resources/settings/privacy_page/privacy_page.js
+++ b/chrome/browser/resources/settings/privacy_page/privacy_page.js
@@ -68,7 +68,7 @@ Polymer({
onManageCertificatesTap_: function() {
<if expr="use_nss_certs">
var pages = /** @type {!SettingsAnimatedPagesElement} */(this.$.pages);
- pages.setSubpageChain(['manage-certificates']);
+ settings.navigateTo(settings.Route.CERTIFICATES);
</if>
<if expr="is_win or is_macosx">
settings.PrivacyPageBrowserProxyImpl.getInstance().
@@ -79,17 +79,12 @@ Polymer({
/** @private */
onSiteSettingsTap_: function() {
var pages = /** @type {!SettingsAnimatedPagesElement} */(this.$.pages);
- pages.setSubpageChain(['site-settings']);
+ settings.navigateTo(settings.Route.SITE_SETTINGS);
},
/** @private */
onClearBrowsingDataTap_: function() {
- this.currentRoute = {
- page: 'advanced',
- section: 'privacy',
- subpage: [],
- dialog: 'clear-browsing-data',
- };
+ settings.navigateTo(settings.Route.CLEAR_BROWSER_DATA);
},
/**
@@ -97,14 +92,7 @@ Polymer({
* @private
*/
onIronOverlayClosed_: function(event) {
- if (Polymer.dom(event).rootTarget.tagName != 'CR-DIALOG')
- return;
-
- this.currentRoute = {
- page: 'advanced',
- section: 'privacy',
- subpage: [],
- // Drop dialog key.
- };
+ if (Polymer.dom(event).rootTarget.tagName == 'CR-DIALOG')
+ settings.navigateTo(settings.Route.PRIVACY);
},
});
« no previous file with comments | « chrome/browser/resources/settings/privacy_page/privacy_page.html ('k') | chrome/browser/resources/settings/route.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698