Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2145)

Unified Diff: chrome/browser/resources/settings/people_page/people_page.js

Issue 2156413002: Settings Router Refactor: Migrate to settings.Route.navigateTo calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use timing fix Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/people_page/people_page.js
diff --git a/chrome/browser/resources/settings/people_page/people_page.js b/chrome/browser/resources/settings/people_page/people_page.js
index 78452d1b7c6cd308a711b4bc0d1940261ff0cbfe..da7f0ea39ce99f1873f4ad964ac437eb33d68ec7 100644
--- a/chrome/browser/resources/settings/people_page/people_page.js
+++ b/chrome/browser/resources/settings/people_page/people_page.js
@@ -184,17 +184,17 @@ Polymer({
/** @private */
onPictureTap_: function() {
<if expr="chromeos">
- this.$.pages.setSubpageChain(['changePicture']);
+ settings.navigateTo(settings.Route.CHANGE_PICTURE);
</if>
<if expr="not chromeos">
- this.$.pages.setSubpageChain(['manageProfile']);
+ settings.navigateTo(settings.Route.MANAGE_PROFILE);
</if>
},
<if expr="not chromeos">
/** @private */
onProfileNameTap_: function() {
- this.$.pages.setSubpageChain(['manageProfile']);
+ settings.navigateTo(settings.Route.MANAGE_PROFILE);
},
</if>
@@ -235,13 +235,13 @@ Polymer({
if (this.syncStatus.managed)
return;
- this.$.pages.setSubpageChain(['sync']);
+ settings.navigateTo(settings.Route.SYNC);
},
<if expr="chromeos">
/** @private */
onQuickUnlockTap_: function() {
- this.$.pages.setSubpageChain(['quick-unlock-authenticate']);
+ settings.navigateTo(settings.Route.QUICK_UNLOCK_AUTHENTICATE);
},
/** @private */
@@ -261,7 +261,7 @@ Polymer({
this.syncBrowserProxy_.manageOtherPeople();
</if>
<if expr="chromeos">
- this.$.pages.setSubpageChain(['users']);
+ settings.navigateTo(settings.Route.ACCOUNTS);
</if>
},

Powered by Google App Engine
This is Rietveld 408576698