chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js - Issue 2156413002: Settings Router Refactor: Migrate to settings.Route.navigateTo calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js

Issue 2156413002: Settings Router Refactor: Migrate to settings.Route.navigateTo calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use timing fix Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html ('k') | chrome/browser/resources/settings/people_page/compiled_resources2.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js

diff --git a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js

index 682897be38e4f2db01e07b41d373d4f670c8a7c3..7ee3d2a071d81b04cd7a96a534e3012a27657b2e 100644

--- a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js

+++ b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js

@@ -476,7 +476,7 @@ Polymer({

// Ignore clicking on the toggle button and verify autofill is enabled.

if (Polymer.dom(event).localTarget != this.$.autofillToggle &&

this.getPref('autofill.enabled').value) {

- this.$.pages.setSubpageChain(['manage-autofill']);

+ settings.navigateTo(settings.Route.AUTOFILL);

}

@@ -490,7 +490,7 @@ Polymer({

// enabled.

if (Polymer.dom(event).localTarget != this.$.passwordToggle &&

this.getPref('profile.password_manager_enabled').value) {

- this.$.pages.setSubpageChain(['manage-passwords']);

+ settings.navigateTo(settings.Route.MANAGE_PASSWORDS);

}