chrome/browser/resources/settings/languages_page/languages_page.js - Issue 2156413002: Settings Router Refactor: Migrate to settings.Route.navigateTo calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/languages_page/languages_page.js

Issue 2156413002: Settings Router Refactor: Migrate to settings.Route.navigateTo calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use timing fix Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/languages_page/languages_page.html ('k') | chrome/browser/resources/settings/passwords_and_forms_page/compiled_resources2.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/languages_page/languages_page.js

diff --git a/chrome/browser/resources/settings/languages_page/languages_page.js b/chrome/browser/resources/settings/languages_page/languages_page.js

index dacba09d17d931b8ec7737572103caa97b3c02f8..ea348028ac3e3b204db4a07371d0c736b1bf4115 100644

--- a/chrome/browser/resources/settings/languages_page/languages_page.js

+++ b/chrome/browser/resources/settings/languages_page/languages_page.js

@@ -95,7 +95,7 @@ Polymer({

* @private

onManageLanguagesTap_: function() {

- this.$.pages.setSubpageChain(['manage-languages']);

+ settings.navigateTo(settings.Route.MANAGE_LANGUAGES);

this.forceRenderList_('settings-manage-languages-page');

@@ -154,7 +154,7 @@ Polymer({

onShowLanguageDetailTap_: function(e) {

this.detailLanguage_ = e.model.item;

- this.$.pages.setSubpageChain(['language-detail']);

+ settings.navigateTo(settings.Route.LANGUAGES_DETAIL);

/**

@@ -163,7 +163,7 @@ Polymer({

onManageInputMethodsTap_: function() {

assert(cr.isChromeOS);

- this.$.pages.setSubpageChain(['manage-input-methods']);

+ settings.navigateTo(settings.Route.INPUT_METHODS);

/**

@@ -238,7 +238,7 @@ Polymer({

onEditDictionaryTap_: function() {

assert(!cr.isMac);

- this.$.pages.setSubpageChain(['edit-dictionary']);

+ settings.navigateTo(settings.Route.EDIT_DICTIONARY);

this.forceRenderList_('settings-edit-dictionary-page');