Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6767)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/settings/about_page/about_page.js

Issue 2156413002: Settings Router Refactor: Migrate to settings.Route.navigateTo calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use timing fix Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/about_page/about_page.html ('k') | chrome/browser/resources/settings/about_page/compiled_resources2.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/about_page/about_page.js
diff --git a/chrome/browser/resources/settings/about_page/about_page.js b/chrome/browser/resources/settings/about_page/about_page.js
index 7d1c4114253d94faa61f87bbe0cd623dca7ba6cb..50861b9cdbaab823e0c2e7769acc39753ee36941 100644
--- a/chrome/browser/resources/settings/about_page/about_page.js
+++ b/chrome/browser/resources/settings/about_page/about_page.js
@@ -250,9 +250,7 @@ Polymer({
/** @private */
onDetailedBuildInfoTap_: function() {
- var animatedPages = /** @type {!SettingsAnimatedPagesElement} */ (
- this.$.pages);
- animatedPages.setSubpageChain(['detailed-build-info']);
+ settings.navigateTo(settings.Route.DETAILED_BUILD_INFO);
},
/** @private */
« no previous file with comments | « chrome/browser/resources/settings/about_page/about_page.html ('k') | chrome/browser/resources/settings/about_page/compiled_resources2.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698