Settings Router Refactor: Migrate to settings.Route.navigateTo calls.

chrome/browser/resources/settings/site_settings_page/site_settings_page.js

Index: chrome/browser/resources/settings/site_settings_page/site_settings_page.js
diff --git a/chrome/browser/resources/settings/site_settings_page/site_settings_page.js b/chrome/browser/resources/settings/site_settings_page/site_settings_page.js
index f44f0b39468c90428285b454ba57ca9dba33ea38..594065be69252efba89d4457e480aafe94863932 100644
--- a/chrome/browser/resources/settings/site_settings_page/site_settings_page.js
+++ b/chrome/browser/resources/settings/site_settings_page/site_settings_page.js
@@ -73,26 +73,11 @@ Polymer({
    */
   onTapCategory: function(event) {
     var category = event.currentTarget.getAttribute('category');
-    if (category == settings.ALL_SITES) {
-      this.currentRoute = {
-        page: this.currentRoute.page,
-        section: 'privacy',
-        subpage: ['site-settings', 'all-sites'],
-      };
-    } else if (category == this.ContentSettingsTypes.PROTOCOL_HANDLERS) {
-      this.currentRoute = {
-        page: this.currentRoute.page,
-        section: 'privacy',
-        subpage: ['site-settings', 'protocol-handlers'],
-      };
-    } else {
-      this.categorySelected = this.computeCategoryTextId(category);
-      this.currentRoute = {
-        page: this.currentRoute.page,
-        section: 'privacy',
-        subpage: ['site-settings', 'site-settings-category-' +
-            this.categorySelected],
-      };
-    }
+    if (category == settings.ALL_SITES)
+      settings.navigateTo(settings.Route.SITE_SETTINGS_ALL);
+    else if (category == this.ContentSettingsTypes.PROTOCOL_HANDLERS)
+      settings.navigateTo(settings.Route.SITE_SETTINGS_HANDLERS);

[michaelpg, 2016/07/25 17:28:08]

can this case be merged into the "else" case? I don't see why these need to be
separated if we're using Route objects instead of generating the subpage list.

[tommycli, 2016/07/25 17:38:34]

Done.

+    else
+      settings.navigateTo(this.computeCategoryRoute(category));
   },
 });