Settings Router Refactor: Migrate to settings.Route.navigateTo calls.

chrome/browser/resources/settings/settings_menu/settings_menu.js

Index: chrome/browser/resources/settings/settings_menu/settings_menu.js
diff --git a/chrome/browser/resources/settings/settings_menu/settings_menu.js b/chrome/browser/resources/settings/settings_menu/settings_menu.js
index 016b1a81140829ce6b6a0cd3d660808b7fcb5cf0..de54e56dc6e5f92d823c9740118d7c60718f22d0 100644
--- a/chrome/browser/resources/settings/settings_menu/settings_menu.js
+++ b/chrome/browser/resources/settings/settings_menu/settings_menu.js
@@ -15,7 +15,7 @@ Polymer({
 
     /**
      * The current active route.
-     * @type {!SettingsRoute}
+     * @type {!settings.Route}
      */
     currentRoute: {
       type: Object,
@@ -44,7 +44,7 @@ Polymer({
   },
 
   /**
-   * @param {!SettingsRoute} newRoute
+   * @param {!settings.Route} newRoute
    * @private
    */
   currentRouteChanged_: function(newRoute) {
@@ -82,13 +82,19 @@ Polymer({
    */
   openPage_: function(event) {
     this.ripple_(/** @type {!Node} */(event.currentTarget));
-    var submenuRoute = event.currentTarget.parentNode.dataset.page;
-    if (submenuRoute) {
-      this.currentRoute = {
-        page: submenuRoute,
-        section: event.currentTarget.dataset.section,
-        subpage: [],
-      };
+    var page = event.currentTarget.parentNode.dataset.page;
+    switch (page) {
+      case 'basic':
+        settings.navigateTo(settings.Route.BASIC);

[dschuyler, 2016/07/21 21:58:53]

This looks like it's missing the dataset.section.
How will this work to get to separate sections?

[tommycli, 2016/07/22 19:06:08]

Done. The bound-route-objects approach we discussed yesterday did not work. I
made a workaround for now, and we can try to improve it further later. Does that
seem fine?

+        break;
+      case 'advanced':
+        settings.navigateTo(settings.Route.ADVANCED);
+        break;
+      case 'about':
+        settings.navigateTo(settings.Route.ABOUT);
+        break;
+      default:
+        assertNotReached();
     }
   },