Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: chrome/browser/resources/settings/about_page/about_page.js

Issue 2156413002: Settings Router Refactor: Migrate to settings.Route.navigateTo calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update for route rename Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/about_page/about_page.js
diff --git a/chrome/browser/resources/settings/about_page/about_page.js b/chrome/browser/resources/settings/about_page/about_page.js
index 7d1c4114253d94faa61f87bbe0cd623dca7ba6cb..50861b9cdbaab823e0c2e7769acc39753ee36941 100644
--- a/chrome/browser/resources/settings/about_page/about_page.js
+++ b/chrome/browser/resources/settings/about_page/about_page.js
@@ -250,9 +250,7 @@ Polymer({
/** @private */
onDetailedBuildInfoTap_: function() {
- var animatedPages = /** @type {!SettingsAnimatedPagesElement} */ (
- this.$.pages);
- animatedPages.setSubpageChain(['detailed-build-info']);
+ settings.navigateTo(settings.Route.DETAILED_BUILD_INFO);
Dan Beam 2016/07/22 01:16:10 any .js file that uses either settings.Route.* or
tommycli 2016/07/22 19:06:08 Done. I wasn't trying to irritate - I just wanted
},
/** @private */

Powered by Google App Engine
This is Rietveld 408576698