Settings Router Refactor: Migrate to settings.Route.navigateTo calls.

chrome/browser/resources/settings/settings_menu/settings_menu.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'settings-menu' shows a menu with a hardcoded set of pages and subpages.
  */
 Polymer({
   is: 'settings-menu',
 
   properties: {
     /** @private */
     advancedOpened_: Boolean,
 
     /**
      * The current active route.
-     * @type {!SettingsRoute}
+     * @type {!settings.Route}
      */
     currentRoute: {
       type: Object,
       notify: true,
       observer: 'currentRouteChanged_',
     },
   },
 
   attached: function() {
     document.addEventListener('toggle-advanced-page', function(e) {
       if (e.detail)
         this.$.advancedPage.open();
       else
         this.$.advancedPage.close();
     }.bind(this));
 
     this.$.advancedPage.addEventListener('paper-submenu-open', function() {
       this.fire('toggle-advanced-page', true);
     }.bind(this));
 
     this.$.advancedPage.addEventListener('paper-submenu-close', function() {
       this.fire('toggle-advanced-page', false);
     }.bind(this));
 
     this.fire('toggle-advanced-page', this.currentRoute.page == 'advanced');
   },
 
   /**
-   * @param {!SettingsRoute} newRoute
+   * @param {!settings.Route} newRoute
    * @private
    */
   currentRouteChanged_: function(newRoute) {
     // Sync URL changes to the side nav menu.
 
     if (newRoute.page == 'advanced') {
       this.$.advancedMenu.selected = this.currentRoute.section;
       this.$.basicMenu.selected = null;
     } else if (newRoute.page == 'basic') {
       this.$.advancedMenu.selected = null;
@@ skipping 17 matching lines @@
     ripple.downAction();
     ripple.upAction();
   },
 
   /**
    * @param {!Event} event
    * @private
    */
   openPage_: function(event) {
     this.ripple_(/** @type {!Node} */(event.currentTarget));
-    var submenuRoute = event.currentTarget.parentNode.dataset.page;
-    if (submenuRoute) {
-      this.currentRoute = {
-        page: submenuRoute,
-        section: event.currentTarget.dataset.section,
-        subpage: [],
-      };
-    }
+    var page = event.currentTarget.parentNode.dataset.page;
+    if (!page)
+      return;
+
+    var section = event.currentTarget.dataset.section;
+    var matchingKey = Object.keys(settings.Route).find(function(key) {

[Dan Beam, 2016/07/23 00:17:12]

Object.values()

[tommycli, 2016/07/25 16:47:20]

Closure compiler doesn't accept values(). Even after pulling this morning.

+      var route = settings.Route[key];
+      return route.page == page && route.section == section &&
+          route.subpage.length == 0;

[Dan Beam, 2016/07/23 00:17:12]

can you add a TODO() about what this code should be if .page or .section doesn't
exist?

[tommycli, 2016/07/25 16:47:20]

Done.

+    });
+
+    if (matchingKey)
+      settings.navigateTo(settings.Route[matchingKey]);
   },
 
   /**
    * @param {boolean} opened Whether the menu is expanded.
    * @return {string} Which icon to use.
    * @private
    * */
   arrowState_: function(opened) {
     return opened ? 'settings:arrow-drop-up' : 'cr:arrow-drop-down';
   },
 });