Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Side by Side Diff: chrome/browser/resources/settings/privacy_page/privacy_page.js

Issue 2156413002: Settings Router Refactor: Migrate to settings.Route.navigateTo calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge origin/master Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'settings-privacy-page' is the settings page containing privacy and 7 * 'settings-privacy-page' is the settings page containing privacy and
8 * security settings. 8 * security settings.
9 */ 9 */
10 Polymer({ 10 Polymer({
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 */ 55 */
56 computeShowClearBrowsingDataDialog_: function() { 56 computeShowClearBrowsingDataDialog_: function() {
57 var route = this.currentRoute; 57 var route = this.currentRoute;
58 return route && route.dialog == 'clear-browsing-data'; 58 return route && route.dialog == 'clear-browsing-data';
59 }, 59 },
60 60
61 /** @private */ 61 /** @private */
62 onManageCertificatesTap_: function() { 62 onManageCertificatesTap_: function() {
63 <if expr="use_nss_certs"> 63 <if expr="use_nss_certs">
64 var pages = /** @type {!SettingsAnimatedPagesElement} */(this.$.pages); 64 var pages = /** @type {!SettingsAnimatedPagesElement} */(this.$.pages);
65 pages.setSubpageChain(['manage-certificates']); 65 settings.navigateTo(settings.Route.CERTIFICATES);
66 </if> 66 </if>
67 <if expr="is_win or is_macosx"> 67 <if expr="is_win or is_macosx">
68 settings.PrivacyPageBrowserProxyImpl.getInstance(). 68 settings.PrivacyPageBrowserProxyImpl.getInstance().
69 showManageSSLCertificates(); 69 showManageSSLCertificates();
70 </if> 70 </if>
71 }, 71 },
72 72
73 /** @private */ 73 /** @private */
74 onSiteSettingsTap_: function() { 74 onSiteSettingsTap_: function() {
75 var pages = /** @type {!SettingsAnimatedPagesElement} */(this.$.pages); 75 var pages = /** @type {!SettingsAnimatedPagesElement} */(this.$.pages);
76 pages.setSubpageChain(['site-settings']); 76 settings.navigateTo(settings.Route.SITE_SETTINGS);
77 }, 77 },
78 78
79 /** @private */ 79 /** @private */
80 onClearBrowsingDataTap_: function() { 80 onClearBrowsingDataTap_: function() {
81 this.currentRoute = { 81 settings.navigateTo(settings.Route.CLEAR_BROWSER_DATA);
82 page: 'advanced',
83 section: 'privacy',
84 subpage: [],
85 dialog: 'clear-browsing-data',
86 };
87 }, 82 },
88 83
89 /** 84 /**
90 * @param {!Event} event 85 * @param {!Event} event
91 * @private 86 * @private
92 */ 87 */
93 onIronOverlayClosed_: function(event) { 88 onIronOverlayClosed_: function(event) {
94 if (Polymer.dom(event).rootTarget.tagName != 'CR-DIALOG') 89 if (Polymer.dom(event).rootTarget.tagName != 'CR-DIALOG')
95 return; 90 return;
96 91
97 this.currentRoute = { 92 settings.navigateTo(settings.Route.PRIVACY);
Dan Beam 2016/07/23 00:17:11 nit: if (Polymer.dom(event).rootTarget.tagName ==
tommycli 2016/07/25 16:47:20 Done.
98 page: 'advanced',
99 section: 'privacy',
100 subpage: [],
101 // Drop dialog key.
102 };
103 }, 93 },
104 }); 94 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698