Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: chrome/browser/resources/settings/about_page/about_page.js

Issue 2156413002: Settings Router Refactor: Migrate to settings.Route.navigateTo calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update for route rename Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 'settings-about-page' contains version and OS related 6 * @fileoverview 'settings-about-page' contains version and OS related
7 * information. 7 * information.
8 */ 8 */
9 Polymer({ 9 Polymer({
10 is: 'settings-about-page', 10 is: 'settings-about-page',
(...skipping 232 matching lines...) Expand 10 before | Expand all | Expand 10 after
243 */ 243 */
244 isTargetChannelMoreStable_: function() { 244 isTargetChannelMoreStable_: function() {
245 assert(this.currentChannel_.length > 0); 245 assert(this.currentChannel_.length > 0);
246 assert(this.targetChannel_.length > 0); 246 assert(this.targetChannel_.length > 0);
247 return settings.isTargetChannelMoreStable( 247 return settings.isTargetChannelMoreStable(
248 this.currentChannel_, this.targetChannel_); 248 this.currentChannel_, this.targetChannel_);
249 }, 249 },
250 250
251 /** @private */ 251 /** @private */
252 onDetailedBuildInfoTap_: function() { 252 onDetailedBuildInfoTap_: function() {
253 var animatedPages = /** @type {!SettingsAnimatedPagesElement} */ ( 253 settings.navigateTo(settings.Route.DETAILED_BUILD_INFO);
Dan Beam 2016/07/22 01:16:10 any .js file that uses either settings.Route.* or
tommycli 2016/07/22 19:06:08 Done. I wasn't trying to irritate - I just wanted
254 this.$.pages);
255 animatedPages.setSubpageChain(['detailed-build-info']);
256 }, 254 },
257 255
258 /** @private */ 256 /** @private */
259 onRelaunchAndPowerwashTap_: function() { 257 onRelaunchAndPowerwashTap_: function() {
260 this.lifetimeBrowserProxy_.factoryReset(); 258 this.lifetimeBrowserProxy_.factoryReset();
261 }, 259 },
262 260
263 /** 261 /**
264 * @return {boolean} 262 * @return {boolean}
265 * @private 263 * @private
(...skipping 27 matching lines...) Expand all
293 }, 291 },
294 </if> 292 </if>
295 293
296 <if expr="_google_chrome"> 294 <if expr="_google_chrome">
297 /** @private */ 295 /** @private */
298 onReportIssueTap_: function() { 296 onReportIssueTap_: function() {
299 this.aboutBrowserProxy_.openFeedbackDialog(); 297 this.aboutBrowserProxy_.openFeedbackDialog();
300 }, 298 },
301 </if> 299 </if>
302 }); 300 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698