Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Unified Diff: third_party/WebKit/LayoutTests/css3/flexbox/nested-flexbox-min-size-auto.html

Issue 2156403002: [css-flexbox] Better test for min-height in nested flexboxes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/css3/flexbox/nested-flexbox-min-size-auto.html
diff --git a/third_party/WebKit/LayoutTests/css3/flexbox/nested-flexbox-min-size-auto.html b/third_party/WebKit/LayoutTests/css3/flexbox/nested-flexbox-min-size-auto.html
index cb98aad51ab73ee5786190e926bf29be15a0234b..1c9297dfaf905ea9382555a6f8d180bab211ba97 100644
--- a/third_party/WebKit/LayoutTests/css3/flexbox/nested-flexbox-min-size-auto.html
+++ b/third_party/WebKit/LayoutTests/css3/flexbox/nested-flexbox-min-size-auto.html
@@ -3,13 +3,39 @@
<script src="../../resources/testharness.js"></script>
<script src="../../resources/testharnessreport.js"></script>
<script src="../../resources/check-layout-th.js"></script>
-<body onload="checkLayout('.flexbox')">
-<div id=log></div>
+<style>
+#container {
+ height: 300px;
+ outline: 2px solid black;
+}
-<!-- This isn't "correct" per the spec, but it is an interim fix
- to avoid bad results.
- See https://crbug.com/580196
- -->
-<div class="flexbox column" style="height: 0px;" data-expected-height="0">
- <div data-expected-height="0" style="display: flex;">Some text</div>
+.inner
+{
+ width: 400px;
+ flex: 1;
+ background-color: green;
+}
+</style>
+<script>
+function change() {
+ var container = document.getElementById('container');
+ container.offsetHeight;
+ container.style.height = '80px';
+ checkLayout('#container');
+}
+</script>
+<body onload="change()">
+<p>Green rectangle should be entirely within the black rectangle</p>
+<div id="log"></div>
+<div id="container">
+ <div class="flexbox column" style="height: 100%;">
+ <div class="flexbox flex-one">
+ <div class="flexbox column">
+ <div class="flexbox column flex-one">
+ <div class="inner" data-expected-height="80">
+ </div>
+ </div>
+ </div>
+ </div>
+ </div>
</div>
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698