[css-flexbox] Better test for min-height in nested flexboxes

[css-flexbox] Better test for min-height in nested flexboxes

This adds a much better testcase for bug 580196 -- this is a reduced version
of the original testcase for that bug, to ensure that we don't regress the
actual issue (which I almost did in https://codereview.chromium.org/2157093002/)

The testcase that I'm replacing was just verifying that we don't apply
min-height: auto to nested flexboxes, which is not very valuable.

BUG=580196
R=eae@chromium.org,dgrogan@chromium.org

Committed: https://crrev.com/204e0c39d20004f3d36fee86a1a72f584d5d6538
Cr-Commit-Position: refs/heads/master@{#406156}

[cbiesinger, 2016-07-18 22:11:03]

The CQ bit was checked by cbiesinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 22:12:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eae, 2016-07-18 22:14:07]

LGTM w/suggestions

https://codereview.chromium.org/2156403002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/css3/flexbox/nested-flexbox-min-size-auto.html
(right):

https://codereview.chromium.org/2156403002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/css3/flexbox/nested-flexbox-min-size-auto.html:36:
<div class="flexbox column height-100pct">
style="height: 100%;" instead of trying to encode that in a classname.

https://codereview.chromium.org/2156403002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/css3/flexbox/nested-flexbox-min-size-auto.html:40:
<div class="inner" data-expected-height="100">
You might want to use a different number than 100 here and on line 28 to ensure
that we don't silently convert between percentages and pixels in check-layout.

[cbiesinger, 2016-07-18 22:17:06]

The CQ bit was checked by cbiesinger@chromium.org

[cbiesinger, 2016-07-18 22:17:06]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2156403002/#ps20001
(title: "review comments")

[cbiesinger, 2016-07-18 22:17:09]

https://codereview.chromium.org/2156403002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/css3/flexbox/nested-flexbox-min-size-auto.html
(right):

https://codereview.chromium.org/2156403002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/css3/flexbox/nested-flexbox-min-size-auto.html:36:
<div class="flexbox column height-100pct">
On 2016/07/18 22:14:07, eae wrote:
> style="height: 100%;" instead of trying to encode that in a classname.

Done.

https://codereview.chromium.org/2156403002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/css3/flexbox/nested-flexbox-min-size-auto.html:40:
<div class="inner" data-expected-height="100">
On 2016/07/18 22:14:07, eae wrote:
> You might want to use a different number than 100 here and on line 28 to
ensure
> that we don't silently convert between percentages and pixels in check-layout.

Done.

[commit-bot: I haz the power, 2016-07-18 22:17:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 23:55:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-18 23:55:12]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-18 23:57:45]

Description was changed from

==========
[css-flexbox] Better test for min-height in nested flexboxes

This adds a much better testcase for bug 580196 -- this is a reduced version
of the original testcase for that bug, to ensure that we don't regress the
actual issue (which I almost did in https://codereview.chromium.org/2157093002/)

The testcase that I'm replacing was just verifying that we don't apply
min-height: auto to nested flexboxes, which is not very valuable.

BUG=580196
R=eae@chromium.org,dgrogan@chromium.org
==========

to

==========
[css-flexbox] Better test for min-height in nested flexboxes

This adds a much better testcase for bug 580196 -- this is a reduced version
of the original testcase for that bug, to ensure that we don't regress the
actual issue (which I almost did in https://codereview.chromium.org/2157093002/)

The testcase that I'm replacing was just verifying that we don't apply
min-height: auto to nested flexboxes, which is not very valuable.

BUG=580196
R=eae@chromium.org,dgrogan@chromium.org

Committed: https://crrev.com/204e0c39d20004f3d36fee86a1a72f584d5d6538
Cr-Commit-Position: refs/heads/master@{#406156}
==========

[commit-bot: I haz the power, 2016-07-18 23:57:46]

Patchset 2 (id:??) landed as
https://crrev.com/204e0c39d20004f3d36fee86a1a72f584d5d6538
Cr-Commit-Position: refs/heads/master@{#406156}