chrome/browser/ui/cocoa/history_menu_bridge.mm - Issue 2156373002: Fix restoring individual tabs from recently closed windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/history_menu_bridge.mm

Issue 2156373002: Fix restoring individual tabs from recently closed windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Testify! Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/history_menu_bridge.mm

diff --git a/chrome/browser/ui/cocoa/history_menu_bridge.mm b/chrome/browser/ui/cocoa/history_menu_bridge.mm

index a10f50736fc8783f23bd31da50e1e137aa004438..82ac3853c6eb2becf5fd4f9750b4dc760498e5c8 100644

--- a/chrome/browser/ui/cocoa/history_menu_bridge.mm

+++ b/chrome/browser/ui/cocoa/history_menu_bridge.mm

@@ -180,8 +180,7 @@ void HistoryMenuBridge::TabRestoreServiceChanged(

NSInteger subindex = [[submenu itemArray] count];

std::vector<sessions::TabRestoreService::Tab>::const_iterator it;

for (it = tabs.begin(); it != tabs.end(); ++it) {

- sessions::TabRestoreService::Tab tab = *it;

- HistoryItem* tab_item = HistoryItemForTab(tab);

+ HistoryItem* tab_item = HistoryItemForTab(*it);

if (tab_item) {

item->tabs.push_back(tab_item);

AddItemToMenu(tab_item, submenu.get(), kRecentlyClosed + 1,

« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/history_menu_bridge_unittest.mm » ('j') | no next file with comments »