Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 2156343004: Fix GrGLInterface::validate() to check for GL_OES_sample_shading on ES contexts (Closed)

Created:
4 years, 5 months ago by bsalomon
Modified:
4 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix GrGLInterface::validate() to check for GL_OES_sample_shading on ES contexts GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2156343004 Committed: https://skia.googlesource.com/skia/+/23c4f1acbcbb72f5a5f380bedc3eed0c1c387a04

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/gpu/gl/GrGLInterface.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
bsalomon
4 years, 5 months ago (2016-07-18 21:10:32 UTC) #3
robertphillips
lgtm
4 years, 5 months ago (2016-07-18 21:56:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2156343004/1
4 years, 5 months ago (2016-07-19 13:07:59 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 13:21:59 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/23c4f1acbcbb72f5a5f380bedc3eed0c1c387a04

Powered by Google App Engine
This is Rietveld 408576698