Fix chrome_api and extensions_api gyp dependencies.

Fix chrome_api and extensions_api gyp dependencies.

Declare a direct dependency on each generated headers target when it's used in source files directly. Add each to export_dependent_settings when it's used in public headers, and ensure that the targets containing files that include those headers have direct dependencies on the target containing those headers.

BUG=355443
R=rsleevi@chromium.org, thakis@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260149

[Yoyo Zhou, 2014-03-27 23:13:44]

rsleevi: did you volunteer to review this?
thakis: for OWNERS review.

[Ryan Sleevi, 2014-03-27 23:21:40]

Sounds like there's still some missing dependencies.

I'm not entirely sure the relationship between chrome_api and extensions_api -
that is, which is the superset of what.

if chrome_api is the generated headers, and extensions_api is the
'implementation whose public headers include those generated files, and whose
headers you include in your API', then

chrome_api makes sure to set hard_dependency (may already be handled by the
.gypi)
extensions_api depends on chrome_api and exports chrome_api
everything that depends on extensions_api and includes public headers exports
extensions_api

Not sure if that made sense?

https://codereview.chromium.org/215633004/diff/1/chrome/chrome_browser_extens...
File chrome/chrome_browser_extensions.gypi (right):

https://codereview.chromium.org/215633004/diff/1/chrome/chrome_browser_extens...
chrome/chrome_browser_extensions.gypi:69:
'common/extensions/api/api.gyp:chrome_api',
In order for export_dependent_settings to work, it also needs to be within the
'dependencies' section (you depend on extensions_api, but export chrome_api)

I wasn't sure if this was a typo or something else.

[Yoyo Zhou, 2014-03-28 00:12:05]

Sorry if it's not clear what chrome_api and extensions_api are. They're both
separate from each other but similar - each uses JSON schema compiler to
generate its headers. (All of the APIs were formerly in chrome_api, but some of
them were split off into extensions_api.) So both of them have hard_dependency:
1.

If it makes more sense, you can think of this as 2 CLs: one of which is just the
chrome_api changes, and one of which is just the extensions_api changes.

https://codereview.chromium.org/215633004/diff/1/chrome/chrome_browser_extens...
File chrome/chrome_browser_extensions.gypi (right):

https://codereview.chromium.org/215633004/diff/1/chrome/chrome_browser_extens...
chrome/chrome_browser_extensions.gypi:69:
'common/extensions/api/api.gyp:chrome_api',
On 2014/03/27 23:21:40, Ryan Sleevi wrote:
> In order for export_dependent_settings to work, it also needs to be within the
> 'dependencies' section (you depend on extensions_api, but export chrome_api)
> 
> I wasn't sure if this was a typo or something else.

chrome_api is already in the dependencies. It's used in header files, whereas
extensions_api is not.

[Ryan Sleevi, 2014-03-28 00:19:59]

Sorry, missed that when reviewing earlier.

This sounds right (LGTM), but I have not reviewed each of the targets' headers.

Still, nothing stands out here as wrong, and less flakiness is best.

https://codereview.chromium.org/215633004/diff/1/chrome/chrome_browser_extens...
File chrome/chrome_browser_extensions.gypi (right):

https://codereview.chromium.org/215633004/diff/1/chrome/chrome_browser_extens...
chrome/chrome_browser_extensions.gypi:69:
'common/extensions/api/api.gyp:chrome_api',
On 2014/03/28 00:12:05, Yoyo Zhou wrote:
> On 2014/03/27 23:21:40, Ryan Sleevi wrote:
> > In order for export_dependent_settings to work, it also needs to be within
the
> > 'dependencies' section (you depend on extensions_api, but export chrome_api)
> > 
> > I wasn't sure if this was a typo or something else.
> 
> chrome_api is already in the dependencies. It's used in header files, whereas
> extensions_api is not.

Doh! I missed that above.

[Nico, 2014-03-28 03:32:44]

lgtm stamp based on rsleevi's review

[Yoyo Zhou, 2014-03-28 06:36:11]

The CQ bit was checked by yoz@chromium.org

[commit-bot: I haz the power, 2014-03-28 06:38:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoz@chromium.org/215633004/1

[commit-bot: I haz the power, 2014-03-28 11:31:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-28 11:31:37]

Retried try job too often on ios_dbg_simulator for step(s) crypto_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[Yoyo Zhou, 2014-03-28 16:13:00]

Committed patchset #1 manually as r260149 (presubmit successful).