Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2156323002: [css-flexbox] Simplify code a bit (Closed)

Created:
4 years, 5 months ago by cbiesinger
Modified:
4 years, 5 months ago
Reviewers:
dgrogan, eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-flexbox] Simplify code a bit No need for these additions/subtractions of border and padding. R=eae@chromium.org,dgrogan@chromium.org BUG=470729 Committed: https://crrev.com/89e80fc1a5930e410e6c2324bb0ba8e01fb53528 Cr-Commit-Position: refs/heads/master@{#406151}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 3 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
cbiesinger
4 years, 5 months ago (2016-07-18 18:38:02 UTC) #1
eae
LGTM This is great, thanks!
4 years, 5 months ago (2016-07-18 18:52:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2156323002/1
4 years, 5 months ago (2016-07-18 18:56:24 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/264459)
4 years, 5 months ago (2016-07-18 21:19:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2156323002/1
4 years, 5 months ago (2016-07-18 21:21:55 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 23:49:48 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 23:50:04 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 23:52:30 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/89e80fc1a5930e410e6c2324bb0ba8e01fb53528
Cr-Commit-Position: refs/heads/master@{#406151}

Powered by Google App Engine
This is Rietveld 408576698