Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: src/parsing/parser.h

Issue 2156303002: Implement new Function.prototype.toString and fix CreateDynamicFunction parsing (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix async function constructor Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/parsing/parser.h
diff --git a/src/parsing/parser.h b/src/parsing/parser.h
index 354384e88c5be0d312c250fac7ba845fb32d3968..5329282bccd929121d5d34f4cd940fafdebd2cbd 100644
--- a/src/parsing/parser.h
+++ b/src/parsing/parser.h
@@ -1078,6 +1078,12 @@ class V8_EXPORT_PRIVATE Parser : public NON_EXPORTED_BASE(ParserBase<Parser>) {
++use_counts_[feature];
}
+ // Returns true iff we're parsing the first function literal during
+ // CreateDynamicFunction().
+ V8_INLINE bool IgnoreFunctionName() const {
+ return parameters_end_pos_ != kNoSourcePosition;
+ }
+
// Parser's private field members.
friend class DiscardableZoneScope; // Uses reusable_preparser_.
// FIXME(marja): Make reusable_preparser_ always use its own temp Zone (call
@@ -1101,6 +1107,12 @@ class V8_EXPORT_PRIVATE Parser : public NON_EXPORTED_BASE(ParserBase<Parser>) {
int use_counts_[v8::Isolate::kUseCounterFeatureCount];
int total_preparse_skipped_;
+ // If not kNoSourcePosition, indicates that the first function literal
+ // encountered is a dynamic function, see CreateDynamicFunction(). This field
+ // indicates the correct position of the ')' that closes the parameter list.
+ // After that ')' is encountered, this field is reset to kNoSourcePosition.
+ int parameters_end_pos_;
+
bool parsing_on_main_thread_;
};
« src/objects.cc ('K') | « src/parsing/parse-info.cc ('k') | src/parsing/parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698