Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Issue 2156273002: More work on ContextBuilder (Closed)

Created:
4 years, 5 months ago by Brian Wilkerson
Modified:
4 years, 5 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -25 lines) Patch
M pkg/analyzer/lib/context/declared_variables.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/context/builder.dart View 6 chunks +72 lines, -22 lines 0 comments Download
M pkg/analyzer/test/src/context/builder_test.dart View 4 chunks +183 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 5 months ago (2016-07-18 17:52:43 UTC) #2
scheglov
LGTM
4 years, 5 months ago (2016-07-18 17:57:49 UTC) #3
Brian Wilkerson
4 years, 5 months ago (2016-07-18 17:59:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0932b19dcacbcc2f23747cb1e93d98356a7fec92 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698