Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(956)

Issue 2156243002: Fix DevFS on Android devices (Closed)

Created:
4 years, 5 months ago by Cutch
Modified:
4 years, 5 months ago
Reviewers:
rmacnak, siva
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix DevFS on Android devices - [x] Allow a system temporary directory to be set on Android. - [x] This is set on Flutter's engine startup path which fixes DevFS on Android devices. Related to https://github.com/dart-lang/sdk/issues/4413 BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/b6e17330ed65c616a64831dbfa1027e5eaef47d6

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -0 lines) Patch
M runtime/bin/directory.h View 2 chunks +3 lines, -0 lines 0 comments Download
M runtime/bin/directory.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M runtime/bin/directory_android.cc View 1 chunk +3 lines, -0 lines 2 comments Download
M runtime/bin/embedded_dart_io.h View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/bin/embedded_dart_io.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M runtime/observatory/tests/service/test_helper.dart View 1 chunk +57 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Cutch
4 years, 5 months ago (2016-07-18 17:14:10 UTC) #4
Cutch
+rmacnak
4 years, 5 months ago (2016-07-18 17:41:35 UTC) #6
rmacnak
lgtm https://codereview.chromium.org/2156243002/diff/1/runtime/bin/directory_android.cc File runtime/bin/directory_android.cc (right): https://codereview.chromium.org/2156243002/diff/1/runtime/bin/directory_android.cc#newcode413 runtime/bin/directory_android.cc:413: // TODO(4413): In the long run, when running ...
4 years, 5 months ago (2016-07-18 17:41:50 UTC) #7
Cutch
https://codereview.chromium.org/2156243002/diff/1/runtime/bin/directory_android.cc File runtime/bin/directory_android.cc (right): https://codereview.chromium.org/2156243002/diff/1/runtime/bin/directory_android.cc#newcode413 runtime/bin/directory_android.cc:413: // TODO(4413): In the long run, when running in ...
4 years, 5 months ago (2016-07-18 17:44:58 UTC) #9
Cutch
4 years, 5 months ago (2016-07-18 17:46:00 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b6e17330ed65c616a64831dbfa1027e5eaef47d6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698