Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(954)

Issue 215623003: Revert "Support replacement of IP address resolutions via command line flag" (Closed)

Created:
6 years, 9 months ago by Ryan Hamilton
Modified:
6 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam, mmenke
Visibility:
Public.

Description

Revert "Support replacement of IP address resolutions via command line flag" Original CL: http://crrev.com/156963003 Preserved ip_pattern* which is now being used by the DnsConfigService. BUG=347382 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260230

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -696 lines) Patch
M chrome/browser/io_thread.cc View 3 chunks +11 lines, -24 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
D net/base/ip_mapping_rules.h View 1 chunk +0 lines, -90 lines 0 comments Download
D net/base/ip_mapping_rules.cc View 1 chunk +0 lines, -120 lines 0 comments Download
D net/base/ip_mapping_rules_unittest.cc View 1 chunk +0 lines, -307 lines 0 comments Download
D net/dns/mapped_ip_resolver.h View 1 chunk +0 lines, -76 lines 0 comments Download
D net/dns/mapped_ip_resolver.cc View 1 chunk +0 lines, -69 lines 0 comments Download
M net/net.gyp View 3 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Ryan Hamilton
6 years, 9 months ago (2014-03-27 23:07:00 UTC) #1
jar (doing other things)
lgtm
6 years, 9 months ago (2014-03-27 23:20:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/215623003/1
6 years, 9 months ago (2014-03-27 23:21:20 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 23:45:40 UTC) #4
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=58137
6 years, 9 months ago (2014-03-27 23:45:41 UTC) #5
Ryan Hamilton
creis: content/ approval sky: iothread approval
6 years, 9 months ago (2014-03-27 23:49:39 UTC) #6
Charlie Reis
content/ LGTM. (I'm confused: is this reverting a CL? Can you put the revision number ...
6 years, 9 months ago (2014-03-28 01:11:40 UTC) #7
Ryan Hamilton
On 2014/03/28 01:11:40, Charlie Reis wrote: > content/ LGTM. Thanks > (I'm confused: is this ...
6 years, 9 months ago (2014-03-28 03:01:04 UTC) #8
sky
io_thread.cc LGTM
6 years, 9 months ago (2014-03-28 15:52:27 UTC) #9
Ryan Hamilton
The CQ bit was checked by rch@chromium.org
6 years, 9 months ago (2014-03-28 16:00:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/215623003/1
6 years, 9 months ago (2014-03-28 16:01:50 UTC) #11
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 19:18:24 UTC) #12
Message was sent while issue was closed.
Change committed as 260230

Powered by Google App Engine
This is Rietveld 408576698