Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 2156213002: Remove FormDataNewMethods runtime flag (status=stable) (Closed)

Created:
4 years, 5 months ago by rwlbuis
Modified:
4 years, 5 months ago
Reviewers:
Mike West, jsbell, eae
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove FormDataNewMethods runtime flag (status=stable) BUG=402536 Committed: https://crrev.com/910be4975b6ef55b18a23377d53c9eb5c8cae0f7 Cr-Commit-Position: refs/heads/master@{#406993}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M third_party/WebKit/Source/core/html/FormData.idl View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 23 (11 generated)
rwlbuis
PTAL, seems this has been stable since 6 months.
4 years, 5 months ago (2016-07-18 17:14:58 UTC) #3
jsbell
lgtm
4 years, 5 months ago (2016-07-18 17:22:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2156213002/1
4 years, 5 months ago (2016-07-18 17:34:51 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/219773)
4 years, 5 months ago (2016-07-18 17:44:46 UTC) #8
jsbell
eae@ - since mkwst is OOO can you r? cq?
4 years, 5 months ago (2016-07-21 16:40:23 UTC) #11
rwlbuis
On 2016/07/21 16:40:23, jsbell wrote: > eae@ - since mkwst is OOO can you r? ...
4 years, 5 months ago (2016-07-21 17:15:06 UTC) #12
eae
RS LGTM
4 years, 5 months ago (2016-07-21 17:56:43 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2156213002/1
4 years, 5 months ago (2016-07-21 17:57:35 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/259893)
4 years, 5 months ago (2016-07-21 22:27:46 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2156213002/1
4 years, 5 months ago (2016-07-21 22:31:58 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 23:44:07 UTC) #21
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 23:45:58 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/910be4975b6ef55b18a23377d53c9eb5c8cae0f7
Cr-Commit-Position: refs/heads/master@{#406993}

Powered by Google App Engine
This is Rietveld 408576698