Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2156203003: shell::ApplicationRunner -> shell::ServiceRunner (Closed)

Created:
4 years, 5 months ago by Ben Goodger (Google)
Modified:
4 years, 5 months ago
CC:
chromium-reviews, rjkroege, feature-media-reviews_chromium.org, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, alokp+watch_chromium.org, kalyank, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

shell::ApplicationRunner -> shell::ServiceRunner TBR=rockot@chromium.org BUG=none Committed: https://crrev.com/e7af97e9c3bde37e2015b46903652dee2fc525d6 Cr-Commit-Position: refs/heads/master@{#406381}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -291 lines) Patch
M ash/mus/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/sysui/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/filesystem/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/font_service/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/leveldb/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mash/app_driver/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mash/browser/browser.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/browser/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mash/catalog_viewer/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mash/example/views_examples/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mash/init/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mash/login/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mash/quick_launch/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mash/quick_launch/quick_launch_application.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/screenlock/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mash/session/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mash/task_viewer/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mash/webtest/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mash/webtest/webtest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/main.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/public/cpp/bindings/tests/versioning_test_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/background/tests/test_service.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M services/shell/public/cpp/BUILD.gn View 3 chunks +2 lines, -2 lines 0 comments Download
D services/shell/public/cpp/application_runner.h View 1 chunk +0 lines, -76 lines 0 comments Download
D services/shell/public/cpp/lib/application_runner.cc View 1 chunk +0 lines, -91 lines 0 comments Download
M services/shell/public/cpp/lib/init_commandline.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + services/shell/public/cpp/lib/service_runner.cc View 1 4 chunks +19 lines, -19 lines 0 comments Download
A + services/shell/public/cpp/service_runner.h View 1 5 chunks +17 lines, -17 lines 0 comments Download
M services/shell/shell_public.gyp View 2 chunks +5 lines, -5 lines 0 comments Download
M services/shell/tests/connect/connect_test_app.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M services/shell/tests/connect/connect_test_class_app.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M services/shell/tests/connect/connect_test_package.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M services/shell/tests/connect/connect_test_singleton_app.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M services/shell/tests/lifecycle/app.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M services/shell/tests/lifecycle/app_client.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M services/shell/tests/lifecycle/package.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M services/shell/tests/lifecycle/parent.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M services/shell/tests/shutdown/shutdown_client_app.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M services/shell/tests/shutdown/shutdown_service_app.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M services/tracing/main.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M services/tracing/tracing_app.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M services/ui/demo/main.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M services/ui/main.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M services/ui/service.h View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/test_wm/test_wm.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
Ben Goodger (Google)
4 years, 5 months ago (2016-07-19 19:45:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2156203003/40001
4 years, 5 months ago (2016-07-19 20:01:01 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-19 21:22:26 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 21:22:41 UTC) #16
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 21:25:27 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e7af97e9c3bde37e2015b46903652dee2fc525d6
Cr-Commit-Position: refs/heads/master@{#406381}

Powered by Google App Engine
This is Rietveld 408576698