Improve performance of Dart_ListGetAsBytes.

runtime/vm/dart_api_impl_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/builtin.h"
 #include "include/dart_api.h"
 #include "include/dart_mirrors_api.h"
 #include "include/dart_native_api.h"
 #include "platform/assert.h"
 #include "platform/json.h"
@@ skipping 814 matching lines @@
   result = Dart_ListSetAsBytes(list_access_test_obj, 0, native_array, 3);
   EXPECT(Dart_IsError(result));
   EXPECT(Dart_IsUnhandledExceptionError(result));
 
   result = Dart_ListSetAt(list_access_test_obj, 0, Dart_NewInteger(42));
   EXPECT(Dart_IsError(result));
   EXPECT(Dart_IsUnhandledExceptionError(result));
 }
 
 
+TEST_CASE(TypedDataViewListGetAsBytes) {
+  const int kSize = 1000;
+
+  const char* kScriptChars =
+      "import 'dart:typed_data';\n"
+      "List main(int size) {"

[ricow1, 2013/08/01 16:29:50]

add \n here and below

[Florian Schneider, 2013/08/02 11:07:33]

Done.

[Florian Schneider, 2013/08/02 11:07:33]

Done.

+      "  var a = new Int8List(size);"
+      "  var view = new Int8List.view(a.buffer, 0, size);"
+      "  return view;"
+      "}\n";
+  // Create a test library and Load up a test script in it.
+  Dart_Handle lib = TestCase::LoadTestScript(kScriptChars, NULL);
+
+  // Test with a typed data view object.
+  Dart_Handle dart_args[1];
+  dart_args[0] = Dart_NewInteger(kSize);
+  Dart_Handle view_obj = Dart_Invoke(lib, NewString("main"), 1, dart_args);
+  EXPECT_VALID(view_obj);
+  for (intptr_t i = 0; i < kSize; ++i) {
+    EXPECT_VALID(Dart_ListSetAt(view_obj, i, Dart_NewInteger(i & 0xff)));
+  }
+  uint8_t* data = new uint8_t[kSize];
+  EXPECT_VALID(Dart_ListGetAsBytes(view_obj, 0, data, kSize));
+  for (intptr_t i = 0; i < kSize; ++i) {
+    EXPECT_EQ(i & 0xff, data[i]);
+  }
+
+  Dart_Handle result = Dart_ListGetAsBytes(view_obj, 0, data, kSize + 1);
+  EXPECT(Dart_IsError(result));
+  delete[] data;
+}
+
+
 TEST_CASE(TypedDataAccess) {
   EXPECT_EQ(Dart_TypedData_kInvalid,
             Dart_GetTypeOfTypedData(Dart_True()));
   EXPECT_EQ(Dart_TypedData_kInvalid,
             Dart_GetTypeOfExternalTypedData(Dart_False()));
   Dart_Handle byte_array1 = Dart_NewTypedData(Dart_TypedData_kUint8, 10);
   EXPECT_VALID(byte_array1);
   EXPECT_EQ(Dart_TypedData_kUint8,
             Dart_GetTypeOfTypedData(byte_array1));
   EXPECT_EQ(Dart_TypedData_kInvalid,
@@ skipping 7415 matching lines @@
   EXPECT(Dart_IsError(Dart_GetClass(lib, NewString("baw"))));
   // Variables foo1 and foo2 are unambiguous.
   EXPECT(!Dart_IsError(Dart_LookupVariable(lib, NewString("foo1"))));
   EXPECT(!Dart_IsError(Dart_LookupVariable(lib, NewString("foo2"))));
   // Functions bar1 and bar2 are unambiguous.
   EXPECT(!Dart_IsError(Dart_LookupFunction(lib, NewString("bar1"))));
   EXPECT(!Dart_IsError(Dart_LookupFunction(lib, NewString("bar2"))));
 }
 
 }  // namespace dart