chromecast/public/DEPS - Issue 2156193003: [Chromecast] Add a custom CastMediaClient for Chromecast

Side by Side Diff: chromecast/public/DEPS

Issue 2156193003: [Chromecast] Add a custom CastMediaClient for Chromecast (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@codecs

Patch Set: Mark MediaCapShlib::IsSupportedVideoConfig as weak symbol Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 include_rules = [	1 include_rules = [

2 # chromecast/public should not depend on anything Chromium specific	2 # chromecast/public should not depend on anything Chromium specific

3 "-chromecast",	3 "-chromecast",

4 "-base",	4 "-base",

5 "-content",	5 "-content",

6 "-net",	6 "-net",

7 "-ui",	7 "-ui",

	8 # Explicity allow chromecast/public header to include chromecast/public/media headers.

	9 "+chromecast/public/media",
	halliwell 2016/07/27 14:23:17 Doesn't look like you're using this capability? Doesn't look like you're using this capability? servolk 2016/07/27 18:56:34 This is actually necessary, without it the deps ch Show quoted text On 2016/07/27 14:23:17, halliwell wrote: > Doesn't look like you're using this capability? This is actually necessary, without it the deps check would fail: Presubmit ERRORS You added one or more #includes that violate checkdeps rules. chromecast/public/media_codec_support_shlib.h Illegal include: "chromecast/public/media/decoder_config.h" Because of no rule applying. (and similarly it would still complaint now, with the shorter relative include file name, so keeping this for now). halliwell 2016/07/27 19:58:48 You can write the include differently, just: #incl Show quoted text On 2016/07/27 18:56:34, servolk wrote: > On 2016/07/27 14:23:17, halliwell wrote: > > Doesn't look like you're using this capability? > > This is actually necessary, without it the deps check would fail: > Presubmit ERRORS > You added one or more #includes that violate checkdeps rules. > chromecast/public/media_codec_support_shlib.h > Illegal include: "chromecast/public/media/decoder_config.h" > Because of no rule applying. > > (and similarly it would still complaint now, with the shorter relative include > file name, so keeping this for now). You can write the include differently, just: #include "decoder_config.h" (see media_pipeline_backend.h for exampl). Then you can revert this DEPS change. servolk 2016/07/27 21:11:38 The difference is that media_pipeline_backend.h is Show quoted text On 2016/07/27 19:58:48, halliwell wrote: > On 2016/07/27 18:56:34, servolk wrote: > > On 2016/07/27 14:23:17, halliwell wrote: > > > Doesn't look like you're using this capability? > > > > This is actually necessary, without it the deps check would fail: > > Presubmit ERRORS > > You added one or more #includes that violate checkdeps rules. > > chromecast/public/media_codec_support_shlib.h > > Illegal include: "chromecast/public/media/decoder_config.h" > > Because of no rule applying. > > > > (and similarly it would still complaint now, with the shorter relative include > > file name, so keeping this for now). > > You can write the include differently, just: > #include "decoder_config.h" > > (see media_pipeline_backend.h for exampl). > > Then you can revert this DEPS change. The difference is that media_pipeline_backend.h is in chromecast/public/media/, i.e. the same directory as decoder_config.h. Whereas media_codec_support_shlib.h is in chromecast/public. When I tried to include just "decoder_config.h" I got build errors. I guess we could add chromecast/public/media/ into include paths in our .gn files. But I'm not sure if that would affect/break vendor builds. Gaofeng, do vendors use GN for their builds?
8 ]	10 ]

OLD	NEW

« chromecast/common/media/cast_media_client.cc ('K') | « chromecast/public/BUILD.gn ('k') | chromecast/public/media/decoder_config.h » ('j') | chromecast/public/media/decoder_config.h » ('J')