Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Issue 2156183003: Add mac GYP builder to cq at 10%, bump win cq builder to 50%. (Closed)

Created:
4 years, 5 months ago by Dirk Pranke
Modified:
4 years, 5 months ago
Reviewers:
Sergey Berezin
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add mac GYP builder to cq at 10%, bump win cq builder to 50%. As long as we can't drop GYP support, we should have some coverage in the CQ to make sheriffing easier. R=sergeyberezin@chromium.org BUG=629152 Committed: https://crrev.com/e601c113c4864b08cc75ee97e189fb018bf7aa01 Cr-Commit-Position: refs/heads/master@{#406201}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M infra/config/cq.cfg View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
Dirk Pranke
We probably shouldn't push the mac build past 10% until https://codereview.chromium.org/2158123002/ lands and we move ...
4 years, 5 months ago (2016-07-18 19:04:15 UTC) #1
Sergey Berezin
LGTM. Indeed, please wait for the mac builder to move to a bigger pool before ...
4 years, 5 months ago (2016-07-18 19:27:04 UTC) #2
Sergey Berezin
On 2016/07/18 19:27:04, Sergey Berezin wrote: > LGTM. Indeed, please wait for the mac builder ...
4 years, 5 months ago (2016-07-18 19:35:08 UTC) #3
Dirk Pranke
On 2016/07/18 19:35:08, Sergey Berezin wrote: > I actually checked how the optional pool is ...
4 years, 5 months ago (2016-07-19 03:21:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2156183003/1
4 years, 5 months ago (2016-07-19 03:21:45 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 03:27:34 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 03:27:36 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 03:30:04 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e601c113c4864b08cc75ee97e189fb018bf7aa01
Cr-Commit-Position: refs/heads/master@{#406201}

Powered by Google App Engine
This is Rietveld 408576698