Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2156183002: Revert of remove unused TableMaskFilter (Closed)

Created:
4 years, 5 months ago by jcgregorio
Modified:
4 years, 5 months ago
Reviewers:
djsollen, f(malita), reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of remove unused TableMaskFilter (patchset #1 id:1 of https://codereview.chromium.org/2156463002/ ) Reason for revert: Needed for Android: frameworks/base/core/jni/android/graphics/MaskFilter.cpp:5:10: fatal error: 'SkTableMaskFilter.h' file not found Original issue's description: > remove unused TableMaskFilter > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2156463002 > > TBR= > > Committed: https://skia.googlesource.com/skia/+/59779ae8ce316bf8b8082ec2df1683ccd38161f1 TBR=reed@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=skia: Committed: https://skia.googlesource.com/skia/+/eb9a84aa576e6278afca6f0cbef4ac80d85cc001

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -0 lines) Patch
M gyp/effects.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
A include/effects/SkTableMaskFilter.h View 1 chunk +66 lines, -0 lines 0 comments Download
A src/effects/SkTableMaskFilter.cpp View 1 chunk +145 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jcgregorio
Created Revert of remove unused TableMaskFilter
4 years, 5 months ago (2016-07-18 14:43:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2156183002/1
4 years, 5 months ago (2016-07-18 14:43:59 UTC) #3
reed1
This appears to only be used by Android (java). Should we move it into android ...
4 years, 5 months ago (2016-07-18 14:50:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/eb9a84aa576e6278afca6f0cbef4ac80d85cc001
4 years, 5 months ago (2016-07-18 15:18:55 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 15:18:57 UTC) #8
Message was sent while issue was closed.
CQ bit was unchecked.

Powered by Google App Engine
This is Rietveld 408576698