Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2156153002: Move function map creation code from boostrapper to factory (Closed)

Created:
4 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 5 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move function map creation code from boostrapper to factory I want to use those methods from ApiNatives so move them to a shared location. BUG= R=verwaest@chromium.org Committed: https://crrev.com/e01fef39f3de5b80255c678a9a792f4992960ed0 Cr-Commit-Position: refs/heads/master@{#37843}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -151 lines) Patch
M src/bootstrapper.cc View 9 chunks +10 lines, -151 lines 0 comments Download
M src/factory.h View 3 chunks +24 lines, -0 lines 0 comments Download
M src/factory.cc View 2 chunks +117 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
jochen (gone - plz use gerrit)
4 years, 5 months ago (2016-07-18 14:10:29 UTC) #1
Toon Verwaest
lgtm
4 years, 5 months ago (2016-07-18 14:20:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2156153002/1
4 years, 5 months ago (2016-07-18 15:11:28 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 15:35:43 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 15:39:20 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e01fef39f3de5b80255c678a9a792f4992960ed0
Cr-Commit-Position: refs/heads/master@{#37843}

Powered by Google App Engine
This is Rietveld 408576698