Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2156143002: Add page coordinates to the ViewportAPI (Closed)

Created:
4 years, 5 months ago by ymalik
Modified:
4 years, 5 months ago
Reviewers:
bokan
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add page coordinates to the ViewportAPI BUG=629082 Committed: https://crrev.com/7894206ab33a91157bfa41b6cee9092dfa079144 Cr-Commit-Position: refs/heads/master@{#406348}

Patch Set 1 #

Patch Set 2 : rebase + fix layout tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -18 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/viewport/verify-viewport-dimensions.html View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-iframe.html View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMVisualViewport.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMVisualViewport.cpp View 1 2 chunks +31 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 1 chunk +10 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/frame/VisualViewport.idl View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
ymalik
4 years, 5 months ago (2016-07-18 14:13:56 UTC) #3
bokan
lgtm
4 years, 5 months ago (2016-07-19 16:15:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2156143002/20001
4 years, 5 months ago (2016-07-19 17:29:54 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-19 19:25:50 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 19:25:59 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 19:27:45 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/7894206ab33a91157bfa41b6cee9092dfa079144
Cr-Commit-Position: refs/heads/master@{#406348}

Powered by Google App Engine
This is Rietveld 408576698