Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2156123003: valgrind: Remove exclusion of non-existent test (Closed)

Created:
4 years, 5 months ago by Irfan
Modified:
4 years, 5 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

valgrind: Remove exclusion of non-existent tests TBR=thestig@chromium.org BUG=484351, 484852 Committed: https://crrev.com/2d43baf55832104578dde52398850a3b3da9bfed Cr-Commit-Position: refs/heads/master@{#406060}

Patch Set 1 #

Patch Set 2 : valgrind: Remove exclusion of non-existent tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M tools/valgrind/gtest_exclude/content_browsertests.gtest-drmemory.txt View 1 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2156123003/20001
4 years, 5 months ago (2016-07-18 19:17:03 UTC) #9
Lei Zhang
lgtm, just 1 BUG= line.
4 years, 5 months ago (2016-07-18 19:18:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2156123003/20001
4 years, 5 months ago (2016-07-18 19:19:24 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-18 19:25:34 UTC) #16
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 19:25:36 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 19:28:44 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2d43baf55832104578dde52398850a3b3da9bfed
Cr-Commit-Position: refs/heads/master@{#406060}

Powered by Google App Engine
This is Rietveld 408576698