Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3962)

Unified Diff: chrome/browser/banners/app_banner_manager_desktop.h

Issue 2156113002: Replace AppBannerDataFetcher with InstallableManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@banner-refactor
Patch Set: Naming, includes Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_manager_desktop.h
diff --git a/chrome/browser/banners/app_banner_manager_desktop.h b/chrome/browser/banners/app_banner_manager_desktop.h
index c45a82189bc000f532d432840f824e511ef413f4..1ee201cf9aec1e59778f34a710e03c08d38d4538 100644
--- a/chrome/browser/banners/app_banner_manager_desktop.h
+++ b/chrome/browser/banners/app_banner_manager_desktop.h
@@ -10,24 +10,44 @@
#include "base/macros.h"
#include "content/public/browser/web_contents_user_data.h"
+namespace extensions {
+class BookmarkAppHelper;
+}
+
namespace banners {
+// Manages web app banners for desktop platforms.
class AppBannerManagerDesktop
: public AppBannerManager,
public content::WebContentsUserData<AppBannerManagerDesktop> {
-
public:
static bool IsEnabled();
- protected:
- AppBannerDataFetcher* CreateAppBannerDataFetcher(
- base::WeakPtr<AppBannerDataFetcher::Delegate> weak_delegate,
- bool is_debug_mode) override;
-
private:
- explicit AppBannerManagerDesktop(content::WebContents* web_contents);
friend class content::WebContentsUserData<AppBannerManagerDesktop>;
+ explicit AppBannerManagerDesktop(content::WebContents* web_contents);
+ ~AppBannerManagerDesktop() override;
+
+ // AppBannerManager overrides.
+ void DidFinishCreatingBookmarkApp(
+ const extensions::Extension* extension,
+ const WebApplicationInfo& web_app_info) override;
+ bool IsWebAppInstalled(content::BrowserContext* browser_context,
+ const GURL& start_url) override;
+ void ShowBanner() override;
+
+ // content::WebContentsObserver override.
+ void DidFinishLoad(content::RenderFrameHost* render_frame_host,
+ const GURL& validated_url) override;
+
+ // SiteEngagementObserver override.
+ void OnEngagementIncreased(content::WebContents* web_contents,
+ const GURL& url,
+ double score) override;
+
+ std::unique_ptr<extensions::BookmarkAppHelper> bookmark_app_helper_;
+
DISALLOW_COPY_AND_ASSIGN(AppBannerManagerDesktop);
};
« no previous file with comments | « chrome/browser/banners/app_banner_manager_browsertest.cc ('k') | chrome/browser/banners/app_banner_manager_desktop.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698