chrome/browser/banners/app_banner_settings_helper.cc - Issue 2156113002: Replace AppBannerDataFetcher with InstallableManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/banners/app_banner_settings_helper.cc

Issue 2156113002: Replace AppBannerDataFetcher with InstallableManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@banner-refactor

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/banners/app_banner_manager_browsertest.cc ('K') | « chrome/browser/banners/app_banner_manager_emulation.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/banners/app_banner_settings_helper.cc

diff --git a/chrome/browser/banners/app_banner_settings_helper.cc b/chrome/browser/banners/app_banner_settings_helper.cc

index d21570ab3cacc81337c2ea87289d78fb555757e7..7bb09e8a98c20b2340d5a27dab6b11bd25819bca 100644

--- a/chrome/browser/banners/app_banner_settings_helper.cc

+++ b/chrome/browser/banners/app_banner_settings_helper.cc

@@ -15,7 +15,7 @@

#include "base/metrics/field_trial.h"

#include "base/strings/string_number_conversions.h"

#include "base/strings/string_util.h"

-#include "chrome/browser/banners/app_banner_data_fetcher.h"

+#include "chrome/browser/banners/app_banner_manager.h"

#include "chrome/browser/banners/app_banner_metrics.h"

#include "chrome/browser/browser_process.h"

#include "chrome/browser/content_settings/host_content_settings_map_factory.h"

@@ -214,7 +214,7 @@ void AppBannerSettingsHelper::RecordBannerInstallEvent(

web_contents, web_contents->GetURL(),

package_name_or_start_url,

AppBannerSettingsHelper::APP_BANNER_EVENT_DID_ADD_TO_HOMESCREEN,

- banners::AppBannerDataFetcher::GetCurrentTime());

+ banners::AppBannerManager::GetCurrentTime());

rappor::SampleDomainAndRegistryFromGURL(

g_browser_process->rappor_service(),

@@ -233,7 +233,7 @@ void AppBannerSettingsHelper::RecordBannerDismissEvent(