Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 21561002: Fixes for JPEG subset decoding. (Closed)

Created:
7 years, 4 months ago by scroggo
Modified:
7 years, 4 months ago
Reviewers:
djsollen
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fixes for JPEG subset decoding. Ensure that the stream passed to JPEG for subset decoding is neither deleted before it is no longer needed nor deleted an extra time. src/images/SkJpegUtility.h: src/images/SkJpegUtility.cpp: Always ref and unref the stream provided to skjpeg_source_mgr. Add some comments explaining how skjpeg_source_mgr's members handle ownership. Fix a warning comparing signed and unsigned numbers, converting to size_t which is more appropriate for measuring bytes. Remove dead code referring to fMemoryBase and fMemoryBaseSize, which are never used. src/images/SkImageDecoder_libjpeg.cpp: Call the new constructor for skjpeg_source_mgr, which no longer takes a boolean to determine ownership. include/images/SkBitmapRegionDecoder.h src/images/SkBitmapRegionDecoder.cpp: This small shim has been removed, since it is not needed to use Skia's image decoders. Its functionality will be folded into Android. Required for the merge to Android. R=djsollen@google.com Committed: https://code.google.com/p/skia/source/detail?r=10483

Patch Set 1 #

Patch Set 2 : Remove reference to unused file from the gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -93 lines) Patch
M gyp/images.gyp View 1 1 chunk +0 lines, -2 lines 0 comments Download
D include/images/SkBitmapRegionDecoder.h View 1 chunk +0 lines, -54 lines 0 comments Download
D src/images/SkBitmapRegionDecoder.cpp View 1 chunk +0 lines, -14 lines 0 comments Download
M src/images/SkImageDecoder_libjpeg.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/images/SkJpegUtility.h View 1 chunk +5 lines, -5 lines 0 comments Download
M src/images/SkJpegUtility.cpp View 3 chunks +9 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scroggo
7 years, 4 months ago (2013-08-01 14:34:37 UTC) #1
djsollen
lgtm
7 years, 4 months ago (2013-08-01 14:41:33 UTC) #2
scroggo
new patch removes reference to *deleted* file from the gyp.
7 years, 4 months ago (2013-08-01 15:02:40 UTC) #3
djsollen
lgtm
7 years, 4 months ago (2013-08-01 15:03:14 UTC) #4
scroggo
7 years, 4 months ago (2013-08-01 15:03:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r10483 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698