chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h - Issue 2156093002: Remove non-immediate core page load metrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h

Issue 2156093002: Remove non-immediate core page load metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@newcompletecallbacks

Patch Set: address comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h

diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h

index ad86d75dbf83d92df7c3cf706ace2a3a0c2d92b5..7f5ce3f61aaf3b8a737e919fa46609861f72b98b 100644

--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h

+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h

@@ -17,11 +17,8 @@ extern const char kHistogramCommit[];

extern const char kHistogramFirstLayout[];

extern const char kHistogramFirstTextPaint[];

extern const char kHistogramDomContentLoaded[];

-extern const char kHistogramDomLoadingToDomContentLoaded[];

extern const char kHistogramLoad[];

extern const char kHistogramFirstContentfulPaint[];

-extern const char kHistogramFirstContentfulPaintImmediate[];

-extern const char kHistogramDomLoadingToFirstContentfulPaint[];

extern const char kHistogramParseDuration[];

extern const char kHistogramParseBlockedOnScriptLoad[];

« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc » ('j') | no next file with comments »