Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2156063003: [gn] Fix remaining ia32/x86 misconfigurations (Closed)

Created:
4 years, 5 months ago by Michael Achenbach
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gn] Fix remaining ia32/x86 misconfigurations BUG=chromium:474921 NOTRY=true TBR=jochen@chromium.org, vogelheim@chromium.org Committed: https://crrev.com/9f640c93f4ec30c13d2683ae55c0f4ff32e34f09 Cr-Commit-Position: refs/heads/master@{#37839}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M infra/mb/mb_config.pyl View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Michael Achenbach
TBR
4 years, 5 months ago (2016-07-18 13:33:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2156063003/1
4 years, 5 months ago (2016-07-18 13:33:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 13:35:14 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 13:35:17 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 13:37:55 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f640c93f4ec30c13d2683ae55c0f4ff32e34f09
Cr-Commit-Position: refs/heads/master@{#37839}

Powered by Google App Engine
This is Rietveld 408576698