third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h - Issue 2156063002: Preparation for new Promise-based RTCPeerConnection.getStats.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h

Issue 2156063002: Preparation for new Promise-based RTCPeerConnection.getStats. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added UseCounter for the new getStats Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-getStats-promise.html ('K') | « third_party/WebKit/Source/modules/peerconnection/RTCLegacyStatsReport.idl ('k') | third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h

diff --git a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h

index 42f09b2a5cc75a95b9e688eb944361c8d3a67853..e967f99652e9a40f0be960771674431dd53915fa 100644

--- a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h

+++ b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h

@@ -113,7 +113,9 @@ public:

void removeStream(MediaStream*, ExceptionState&);

- void getStats(ExecutionContext*, RTCStatsCallback* successCallback, MediaStreamTrack* selector);

+ ScriptPromise getStats(ScriptState*, ScriptValue);

+ ScriptPromise getStats(ScriptState*, RTCStatsCallback* successCallback, MediaStreamTrack* selector = nullptr);

+ ScriptPromise getStats(ScriptState*, MediaStreamTrack* selector = nullptr);

RTCDataChannel* createDataChannel(String label, const Dictionary& dataChannelDict, ExceptionState&);