third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-statsPromise.html - Issue 2156063002: Preparation for new Promise-based RTCPeerConnection.getStats.

Side by Side Diff: third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-statsPromise.html

Issue 2156063002: Preparation for new Promise-based RTCPeerConnection.getStats. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Replaced TODO /w comment what happens if function != 1 args Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-statsPromise-expected.txt » ('j') | third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">

	2 <html>

	3 <head>

	4 <script src="../../resources/js-test.js"></script>
	hta - Chromium 2016/07/19 09:56:48 This test is new. Can you make it a testharness.js This test is new. Can you make it a testharness.js-based test instead of js-test.js? I think the guidance is that all new tests should be testharness.js-based (which makes it possible to upstream them to the W3C test framework). hbos_chromium 2016/07/19 13:59:34 Done. Much nicer. Show quoted text On 2016/07/19 09:56:48, hta - Chromium wrote: > This test is new. Can you make it a testharness.js-based test instead of > js-test.js? > > I think the guidance is that all new tests should be testharness.js-based (which > makes it possible to upstream them to the W3C test framework). Done. Much nicer.
	5 </head>

	6 <body>

	7 <script>

	8 description("Tests the promise-based RTCPeerConnection.getStats function.");

	9

	10 var pc = null;

	11 var selector = null;

	12

	13 function getUserMedia(dictionary, callback) {

	14 try {

	15 navigator.webkitGetUserMedia(dictionary, callback, error);
	hta - Chromium 2016/07/19 09:56:48 Use navigator.mediaDevices.getUserMedia => promise Use navigator.mediaDevices.getUserMedia => promise for all new stuff, even in tests. hbos_chromium 2016/07/19 13:59:34 Done. Show quoted text On 2016/07/19 09:56:48, hta - Chromium wrote: > Use navigator.mediaDevices.getUserMedia => promise for all new stuff, even in > tests. Done.
	16 } catch (e) {

	17 testFailed('webkitGetUserMedia threw exception :' + e);

	18 finishJSTest();

	19 }

	20 }

	21

	22 function error() {

	23 testFailed('Stream generation failed.');

	24 finishJSTest();

	25 }

	26

	27 function gotStream(stream) {

	28 testPassed('Got a stream.');

	29

	30 pc.addStream(stream);

	31 shouldNotThrow('selector = pc.getLocalStreams()[0].getVideoTracks()[0]');

	32 shouldBeNonNull('selector');

	33

	34 shouldNotThrow('pc.getStats(selector).then(onResolve, onReject1)');

	35 }

	36

	37 function onResolve(report) {

	38 // Until getStats is implemented, we expect the promise to be rejected.

	39 testFailed("onResolve called - getStats promise expected to be rejected.");

	40 finishJSTest();

	41 }

	42 function onReject1(reason) {

	43 testPassed("pc.getStats(selector) was rejected.");

	44 shouldNotThrow('pc.getStats().then(onResolve, onReject2)');
	hta - Chromium 2016/07/19 09:56:48 In general, when testing promises, it's better to In general, when testing promises, it's better to write it as pc.getStats() .then(args => { stuff }) .catch(error => { stuff }); This saves you from defining a million oddly named helper functions. there's a style guide on formatting these, which looks odd, but appears to be the least unreasonable one. See the comments in the getConstraints tests, which uses this format. hbos_chromium 2016/07/19 13:59:34 Done. Show quoted text On 2016/07/19 09:56:48, hta - Chromium wrote: > In general, when testing promises, it's better to write it as > > pc.getStats() > .then(args => { > stuff > }) > .catch(error => { > stuff > }); > > This saves you from defining a million oddly named helper functions. > > there's a style guide on formatting these, which looks odd, but appears to be > the least unreasonable one. > See the comments in the getConstraints tests, which uses this format. Done.
	45 }

	46 function onReject2(reason) {

	47 testPassed("pc.getStats() was rejected.");

	48 finishJSTest();

	49 }

	50

	51 shouldNotThrow('pc = new webkitRTCPeerConnection(null)');

	52 shouldNotThrow('getUserMedia({audio:true, video:true}, gotStream)');

	53

	54 window.jsTestIsAsync = true;

	55 window.successfullyParsed = true;

	56 </script>

	57 </body>

	58 </html>

OLD	NEW