Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Issue 2156043002: Also report peak malloc memory usage from V8 (Closed)

Created:
4 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Also report peak malloc memory usage from V8 R=primiano@chromium.org BUG= Committed: https://crrev.com/077e9d75164f02033b09c634dd87df584a2de93a Cr-Commit-Position: refs/heads/master@{#406345}

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M gin/v8_isolate_memory_dump_provider.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
jochen (gone - plz use gerrit)
4 years, 5 months ago (2016-07-18 10:49:54 UTC) #1
jochen (gone - plz use gerrit)
depends on https://codereview.chromium.org/2153423002 rolling in
4 years, 5 months ago (2016-07-18 10:50:13 UTC) #2
primiano CORP (USE chromium)
https://codereview.chromium.org/2156043002/diff/1/gin/v8_isolate_memory_dump_provider.cc File gin/v8_isolate_memory_dump_provider.cc (right): https://codereview.chromium.org/2156043002/diff/1/gin/v8_isolate_memory_dump_provider.cc#newcode175 gin/v8_isolate_memory_dump_provider.cc:175: std::string peak_malloc_name = dump_base_name + "/malloc_peak"; I think the ...
4 years, 5 months ago (2016-07-18 10:58:00 UTC) #4
jochen (gone - plz use gerrit)
ptal
4 years, 5 months ago (2016-07-18 11:22:50 UTC) #6
primiano CORP (USE chromium)
LGTM. I suppose bots are red because the v8 api hasn't rolled yet.
4 years, 5 months ago (2016-07-18 12:14:45 UTC) #10
Primiano Tucci (use gerrit)
blah multilogin fail, LGTM from the right account (or you'll get a "you didn't receive ...
4 years, 5 months ago (2016-07-19 10:01:54 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2156043002/20001
4 years, 5 months ago (2016-07-19 18:57:43 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-19 19:22:54 UTC) #18
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 19:23:10 UTC) #19
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 19:24:54 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/077e9d75164f02033b09c634dd87df584a2de93a
Cr-Commit-Position: refs/heads/master@{#406345}

Powered by Google App Engine
This is Rietveld 408576698