|
|
Created:
4 years, 5 months ago by jochen (gone - plz use gerrit) Modified:
4 years, 5 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAlso report peak malloc memory usage from V8
R=primiano@chromium.org
BUG=
Committed: https://crrev.com/077e9d75164f02033b09c634dd87df584a2de93a
Cr-Commit-Position: refs/heads/master@{#406345}
Patch Set 1 #
Total comments: 1
Patch Set 2 : updates #Messages
Total messages: 21 (11 generated)
depends on https://codereview.chromium.org/2153423002 rolling in
primiano@google.com changed reviewers: + primiano@google.com
https://codereview.chromium.org/2156043002/diff/1/gin/v8_isolate_memory_dump_... File gin/v8_isolate_memory_dump_provider.cc (right): https://codereview.chromium.org/2156043002/diff/1/gin/v8_isolate_memory_dump_... gin/v8_isolate_memory_dump_provider.cc:175: std::string peak_malloc_name = dump_base_name + "/malloc_peak"; I think the best approach would be reporting this as a column not a row, otherwise would create funky double-counting issues, where we count both the current and peak value. Concretely this means turning this CL into a one-line (% wrapping) as follows: malloc_dump->AddScalar("peak_size", base::trace_event::MemoryAllocatorDump::kUnitsBytes, heap_statistics.peak_malloced_memory())
The CQ bit was checked by jochen@chromium.org to run a CQ dry run
ptal
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
LGTM. I suppose bots are red because the v8 api hasn't rolled yet.
The CQ bit was checked by jochen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
blah multilogin fail, LGTM from the right account (or you'll get a "you didn't receive a lg from a valid committer yet yada yada"
The CQ bit was checked by jochen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Also report peak malloc memory usage from V8 R=primiano@chromium.org BUG= ========== to ========== Also report peak malloc memory usage from V8 R=primiano@chromium.org BUG= Committed: https://crrev.com/077e9d75164f02033b09c634dd87df584a2de93a Cr-Commit-Position: refs/heads/master@{#406345} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/077e9d75164f02033b09c634dd87df584a2de93a Cr-Commit-Position: refs/heads/master@{#406345} |