Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 2156033002: Split out long-running serialization test and add timings to output (Closed)

Created:
4 years, 5 months ago by Johnni Winther
Modified:
4 years, 5 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Split out long-running serialization test and add timings to output BUG= R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/941691650c7ee969c7f40c366dc3d12824d855a4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -149 lines) Patch
M tests/compiler/dart2js/serialization/analysis_test_helper.dart View 2 chunks +23 lines, -22 lines 0 comments Download
M tests/compiler/dart2js/serialization/compilation_test_helper.dart View 2 chunks +14 lines, -13 lines 0 comments Download
M tests/compiler/dart2js/serialization/helper.dart View 2 chunks +77 lines, -21 lines 0 comments Download
A + tests/compiler/dart2js/serialization/model0_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/serialization/model1_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/serialization/model_test_helper.dart View 3 chunks +96 lines, -90 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
4 years, 5 months ago (2016-07-18 10:29:01 UTC) #2
Bill Hesse
lgtm
4 years, 5 months ago (2016-07-18 12:00:44 UTC) #3
Johnni Winther
4 years, 5 months ago (2016-07-18 12:09:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
941691650c7ee969c7f40c366dc3d12824d855a4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698