Put FunctionLiterals into temp_zone too.

Put FunctionLiterals into temp_zone too.

This reduces memory usage when parsing (because temp_zones are discarded
every now and then) and work done by FuncNameInferrer.

BUG=

Committed: https://crrev.com/09a854c72b5954653e0f719fc17d4adbde43598c
Cr-Commit-Position: refs/heads/master@{#37863}

[marja, 2016-07-18 08:03:52]

The CQ bit was checked by marja@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 08:04:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 08:19:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 08:19:12]

Dry run: Try jobs failed on following builders:
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/5162)
  v8_mac_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bui...)

[marja, 2016-07-18 09:56:05]

The CQ bit was checked by marja@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 09:56:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[marja, 2016-07-18 11:06:39]

The CQ bit was checked by marja@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 11:06:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 11:46:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 11:46:02]

Dry run: This issue passed the CQ dry run.

[marja, 2016-07-18 11:47:47]

marja@chromium.org changed reviewers:
+ titzer@chromium.org

[marja, 2016-07-18 11:47:48]

titzer, ptal.

I'm going to get rid of AstNodeFactory::BodyScope in the next CL, so this is an
intermediate state. (After that CL, We wouldn't have parser_zone_ any more, and
everything would go into local_zone_, especially Scopes and everything related
to them.)

[marja, 2016-07-19 07:47:52]

On 2016/07/18 11:47:48, marja wrote:
> titzer, ptal.
> 
> I'm going to get rid of AstNodeFactory::BodyScope in the next CL, so this is
an
> intermediate state. (After that CL, We wouldn't have parser_zone_ any more,
and
> everything would go into local_zone_, especially Scopes and everything related
> to them.)

Hmm, no, I'm not going to get rid of BodyScope, pls disregard that comment :)

[titzer, 2016-07-19 07:55:30]

https://codereview.chromium.org/2156013002/diff/60001/src/parsing/parser.h
File src/parsing/parser.h (right):

https://codereview.chromium.org/2156013002/diff/60001/src/parsing/parser.h#ne...
src/parsing/parser.h:936: class DiscardableZoneScope {
AFAICT the main difference between DiscardableZoneScope and
AstNodeFactory::BodyScope is that the former contains one of the latter and also
manipulates the function name inferrer.

I don't really understand why function name inferrer needs to be swapped out.

Also, can this class live in the .cc file?

[marja, 2016-07-19 09:33:06]

The CQ bit was checked by marja@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 09:33:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[marja, 2016-07-19 09:34:33]

As discussed offline:

- We need a temporary FuncNameInferrer so that we can put FunctionLiterals
discovered in the lazily-compiled functions there.

- Moved the DiscardableZoneScope into the .cc, made it so that it's not an inner
class of Parser but a friend.

[titzer, 2016-07-19 09:35:26]

lgtm

[marja, 2016-07-19 09:37:43]

The CQ bit was unchecked by marja@chromium.org

[marja, 2016-07-19 09:37:49]

The CQ bit was checked by marja@chromium.org

[commit-bot: I haz the power, 2016-07-19 09:38:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 09:43:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 09:43:50]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/19722)

[marja, 2016-07-19 09:48:41]

marja@chromium.org changed reviewers:
+ rossberg@chromium.org

[marja, 2016-07-19 09:48:42]

rossberg@, ptal (you're ast.h owner)

[rossberg, 2016-07-19 11:10:52]

lgtm

[marja, 2016-07-19 11:11:18]

The CQ bit was checked by marja@chromium.org

[commit-bot: I haz the power, 2016-07-19 11:11:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 11:13:32]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-19 11:14:17]

Description was changed from

==========
Put FunctionLiterals into temp_zone too.

This reduces memory usage when parsing (because temp_zones are discarded
every now and then) and work done by FuncNameInferrer.

BUG=
==========

to

==========
Put FunctionLiterals into temp_zone too.

This reduces memory usage when parsing (because temp_zones are discarded
every now and then) and work done by FuncNameInferrer.

BUG=

Committed: https://crrev.com/09a854c72b5954653e0f719fc17d4adbde43598c
Cr-Commit-Position: refs/heads/master@{#37863}
==========

[commit-bot: I haz the power, 2016-07-19 11:14:18]

Patchset 5 (id:??) landed as
https://crrev.com/09a854c72b5954653e0f719fc17d4adbde43598c
Cr-Commit-Position: refs/heads/master@{#37863}