Issue 2156003004: Add an UNDEFINED_IDENTIFIER_AWAIT warning

Issue 2156003004: Add an UNDEFINED_IDENTIFIER_AWAIT warning (Closed)

Created:
4 years, 5 months ago by srawlins

Modified:
4 years, 5 months ago

Reviewers:
sethladd, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add an UNDEFINED_IDENTIFIER_AWAIT warning BUG=https://github.com/dart-lang/sdk/issues/22625 R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/e60c1e4c595aaa264a261314dbd3a7d49a5aa232

Patch Set 1 #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -2 lines)			Patch
M	pkg/analyzer/lib/src/generated/element_resolver.dart	View	1 chunk	+9 lines, -2 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/error.dart	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	pkg/analyzer/test/generated/static_warning_code_test.dart	View	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

srawlins

This is a compromise on https://github.com/dart-lang/sdk/issues/22625 It gives the same warning as dart2js.

4 years, 5 months ago (2016-07-18 15:41:04 UTC) #2

srawlins

Committed patchset #1 (id:1) manually as e60c1e4c595aaa264a261314dbd3a7d49a5aa232 (presubmit successful).

4 years, 5 months ago (2016-07-18 16:45:45 UTC) #5

Paul Berry

On 2016/07/18 16:45:45, srawlins wrote: > Committed patchset #1 (id:1) manually as > e60c1e4c595aaa264a261314dbd3a7d49a5aa232 (presubmit ...

4 years, 5 months ago (2016-07-18 17:16:51 UTC) #6

Message was sent while issue was closed.

On 2016/07/18 16:45:45, srawlins wrote:
> Committed patchset #1 (id:1) manually as
> e60c1e4c595aaa264a261314dbd3a7d49a5aa232 (presubmit successful).

This commit seems to have caused a unit test to regress.

Repro with: python tools/test.py -aia32 --checked -mrelease -t60
pkg/analysis_server/test/services/correction/fix_test

Example failure:

FAIL: FixProcessorTest | test_addSync_blockFunctionBody
  Expected: equals ['Expected to find \';\'', 'Undefined name \'await\'']
unordered
    Actual: MappedListIterable:[
    'Expected to find \';\'',
    'Undefined name \'await\'; did you mean to add the \'async\' marker to
\'main\'?'
  ]
     Which: has no match for 'Undefined name \'await\'' at index 1
  
  package:unittest/src/simple_configuration.dart 128:34            
SimpleConfiguration.onExpectFailure
  package:unittest/src/simple_configuration.dart 24:13             
_ExpectFailureHandler.fail
  package:unittest/src/matcher/expect.dart 121:5                   
DefaultFailureHandler.failMatch
  package:unittest/src/matcher/expect.dart 95:20                    expect
  pkg/analysis_server/test/services/correction/fix_test.dart 468:5 
FixProcessorTest.test_addSync_blockFunctionBody.<async>
  dart:async/future.dart 144                                       
Future.Future.microtask.<fn>
  dart:async/zone.dart 1400                                         _rootRun
  dart:async/zone.dart 1256                                        
_CustomZone.run
  dart:async/zone.dart 1154                                        
_CustomZone.runGuarded
  dart:async/zone.dart 1181                                        
_CustomZone.bindCallback.<fn>
  dart:async/zone.dart 1404                                         _rootRun
  dart:async/zone.dart 1256                                        
_CustomZone.run
  dart:async/zone.dart 1154                                        
_CustomZone.runGuarded
  dart:async/zone.dart 1181                                        
_CustomZone.bindCallback.<fn>
  dart:async/schedule_microtask.dart 41                            
_microtaskLoop
  dart:async/schedule_microtask.dart 50                            
_startMicrotaskLoop
  dart:isolate-patch/timer_impl.dart 394                           
_Timer._runTimers
  dart:isolate-patch/timer_impl.dart 414                           
_Timer._handleMessage
  dart:isolate-patch/isolate_patch.dart 148                        
_RawReceivePortImpl._handleMessage

Would you mind having a look?

scheglov

On 2016/07/18 17:16:51, Paul Berry wrote: > On 2016/07/18 16:45:45, srawlins wrote: > > Committed ...

4 years, 5 months ago (2016-07-18 17:36:18 UTC) #7

Message was sent while issue was closed.

On 2016/07/18 17:16:51, Paul Berry wrote:
> On 2016/07/18 16:45:45, srawlins wrote:
> > Committed patchset #1 (id:1) manually as
> > e60c1e4c595aaa264a261314dbd3a7d49a5aa232 (presubmit successful).
> 
> This commit seems to have caused a unit test to regress.
> 
> Repro with: python tools/test.py -aia32 --checked -mrelease -t60
> pkg/analysis_server/test/services/correction/fix_test
> 
> Example failure:
> 
> FAIL: FixProcessorTest | test_addSync_blockFunctionBody
>   Expected: equals ['Expected to find \';\'', 'Undefined name \'await\'']
> unordered
>     Actual: MappedListIterable:[
>     'Expected to find \';\'',
>     'Undefined name \'await\'; did you mean to add the \'async\' marker to
> \'main\'?'
>   ]
>      Which: has no match for 'Undefined name \'await\'' at index 1
>   
>   package:unittest/src/simple_configuration.dart 128:34            
> SimpleConfiguration.onExpectFailure
>   package:unittest/src/simple_configuration.dart 24:13             
> _ExpectFailureHandler.fail
>   package:unittest/src/matcher/expect.dart 121:5                   
> DefaultFailureHandler.failMatch
>   package:unittest/src/matcher/expect.dart 95:20                    expect
>   pkg/analysis_server/test/services/correction/fix_test.dart 468:5 
> FixProcessorTest.test_addSync_blockFunctionBody.<async>
>   dart:async/future.dart 144                                       
> Future.Future.microtask.<fn>
>   dart:async/zone.dart 1400                                         _rootRun
>   dart:async/zone.dart 1256                                        
> _CustomZone.run
>   dart:async/zone.dart 1154                                        
> _CustomZone.runGuarded
>   dart:async/zone.dart 1181                                        
> _CustomZone.bindCallback.<fn>
>   dart:async/zone.dart 1404                                         _rootRun
>   dart:async/zone.dart 1256                                        
> _CustomZone.run
>   dart:async/zone.dart 1154                                        
> _CustomZone.runGuarded
>   dart:async/zone.dart 1181                                        
> _CustomZone.bindCallback.<fn>
>   dart:async/schedule_microtask.dart 41                            
> _microtaskLoop
>   dart:async/schedule_microtask.dart 50                            
> _startMicrotaskLoop
>   dart:isolate-patch/timer_impl.dart 394                           
> _Timer._runTimers
>   dart:isolate-patch/timer_impl.dart 414                           
> _Timer._handleMessage
>   dart:isolate-patch/isolate_patch.dart 148                        
> _RawReceivePortImpl._handleMessage
> 
> Would you mind having a look?

This CL https://codereview.chromium.org/2162523003 should take care of it by
updating Quick Fixes generator to the new error code.

Message was sent while issue was closed.

See https://codereview.chromium.org/2162523003/

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages