Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2156003002: V4L2VDA: do not queue output buffer during resolution change. (Closed)

Created:
4 years, 5 months ago by wuchengli
Modified:
4 years, 5 months ago
Reviewers:
kcwu
CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org, Pawel Osciak
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

V4L2VDA: do not queue output buffer during resolution change. This issue happens when a resolution change happens right after a reset. First the client requests a reset. The image processor is still processing some buffers and they will be ignored when returning to V4L2VideoAccelerator. Then a resolution change occurs and V4L2VDA stops the output queue. The image processor returns a buffer and V4L2VDA queues it back. Since the queue is stopped, STREAMON will be called to start the queue. Finally REQBUFS will fail during resolution change because the queue is not stopped. The fix is we should not queue the buffer returned from image proessor if a resolution change is in progress. BUG=chrome-os-partner:55347 TEST=Seek when playing switch_1080p_720p.mp4 on oak. The video is from gs://chromiumos-test-assets-public/Shaka-Dash. Committed: https://crrev.com/dbc04d68e9460ff36423ce36afba9508a91cd8bf Cr-Commit-Position: refs/heads/master@{#405991}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M media/gpu/v4l2_video_decode_accelerator.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
wuchengli
4 years, 5 months ago (2016-07-18 07:02:27 UTC) #2
kcwu
lgtm
4 years, 5 months ago (2016-07-18 10:19:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2156003002/1
4 years, 5 months ago (2016-07-18 12:05:14 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/222504)
4 years, 5 months ago (2016-07-18 14:18:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2156003002/1
4 years, 5 months ago (2016-07-18 14:57:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 15:06:32 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 15:09:29 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dbc04d68e9460ff36423ce36afba9508a91cd8bf
Cr-Commit-Position: refs/heads/master@{#405991}

Powered by Google App Engine
This is Rietveld 408576698