Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2155983003: Push GrPipelineBuilder down to the drawBatch calls in the TextContext (Closed)

Created:
4 years, 5 months ago by robertphillips
Modified:
4 years, 5 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Push GrPipelineBuilder down to the drawBatch calls in the TextContext This is split out of https://codereview.chromium.org/2092893003/ (Retract PipelineBuilder some more) GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2155983003 Committed: https://skia.googlesource.com/skia/+/640789d64bcce565856fde5bbfc845d56bb470c8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -27 lines) Patch
M src/gpu/text/GrAtlasTextBlob.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/text/GrAtlasTextBlob.cpp View 5 chunks +10 lines, -12 lines 0 comments Download
M src/gpu/text/GrStencilAndCoverTextContext.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/text/GrStencilAndCoverTextContext.cpp View 7 chunks +9 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
robertphillips
4 years, 5 months ago (2016-07-18 18:35:20 UTC) #4
bsalomon
lgtm
4 years, 5 months ago (2016-07-18 18:50:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2155983003/1
4 years, 5 months ago (2016-07-18 21:55:14 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 21:56:09 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/640789d64bcce565856fde5bbfc845d56bb470c8

Powered by Google App Engine
This is Rietveld 408576698