third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp - Issue 2155973002: Save a bitmap copy when advancing to dependent GIF and WebP animation frames

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp

Issue 2155973002: Save a bitmap copy when advancing to dependent GIF and WebP animation frames (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: +webp. fix test failures. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/image-decoders/ImageFrame.h » ('j') | third_party/WebKit/Source/platform/image-decoders/ImageFrame.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp b/third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp

index 099c7fc42ed311ed31e29be646decb453ef1bc42..1a4a97b82b0f4d754362fa63aed4d549b1a584a1 100644

--- a/third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp

+++ b/third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp

@@ -302,7 +302,7 @@ bool ImageFrameGenerator::decode(SegmentReader* data, bool allDataReceived, size

// the latter case.

const bool isDecodeComplete = frame->getStatus() == ImageFrame::FrameComplete || allDataReceived;

- SkBitmap fullSizeBitmap = frame->bitmap();

+ SkBitmap fullSizeBitmap = frame->bitmap(false);

if (!fullSizeBitmap.isNull()) {

ASSERT(fullSizeBitmap.width() == m_fullSize.width() && fullSizeBitmap.height() == m_fullSize.height());

setHasAlpha(index, !fullSizeBitmap.isOpaque());