third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp - Issue 2155973002: Save a bitmap copy when advancing to dependent GIF and WebP animation frames

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp

Issue 2155973002: Save a bitmap copy when advancing to dependent GIF and WebP animation frames (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: DCHECK in ImageFrame::copy/take. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/exported/WebImage.cpp ('K') | « third_party/WebKit/Source/platform/exported/WebImage.cpp ('k') | third_party/WebKit/Source/platform/graphics/PictureSnapshot.cpp » ('j') | third_party/WebKit/Source/platform/graphics/PictureSnapshot.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp b/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp

index df4b86994d13c1d7ef177299c069132d5ffbdb52..2b69e002ee42b784fce005fc1de2c7976fabb38f 100644

--- a/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp

+++ b/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp

@@ -117,6 +117,8 @@ PassRefPtr<SkImage> DeferredImageDecoder::createFrameAtIndex(size_t index)

if (!frame || frame->getStatus() == ImageFrame::FrameEmpty)

return nullptr;

+ if (frame->getStatus() == ImageFrame::FrameComplete)

+ return fromSkSp(frame->finalizePixelsAndGetImage());

return fromSkSp(SkImage::MakeFromBitmap(frame->bitmap()));

Peter Kasting 2016/09/22 21:44:08 Nit: Avoids duplicating fromSkSp() call: return

aleksandar.stojiljkovic 2016/09/27 18:08:28 Done. The most recent refactoring removed the need

}