Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2155943002: ServiceWorker: Use FrozenArray for *MessageEvent.ports. (Closed)

Created:
4 years, 5 months ago by zino
Modified:
4 years, 5 months ago
Reviewers:
nhiroki
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, haraken, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Use FrozenArray for *MessageEvent.ports. The T[] array type has ben removed from WebIDL. Instead we should use FrozenArray in ServiceWorkerMessageEvent and ExtendableMessageEvent. Related spec issue: https://github.com/slightlyoff/ServiceWorker/issues/810 BUG=628911 Committed: https://crrev.com/541047a6af9e1a9ac0e4c20dcfc0cf952de45c23 Cr-Commit-Position: refs/heads/master@{#406230}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerMessageEvent.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
zino
PTAL
4 years, 5 months ago (2016-07-17 15:17:00 UTC) #4
nhiroki
lgtm
4 years, 5 months ago (2016-07-19 05:16:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2155943002/1
4 years, 5 months ago (2016-07-19 05:20:50 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 07:54:02 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 07:54:08 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 07:56:05 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/541047a6af9e1a9ac0e4c20dcfc0cf952de45c23
Cr-Commit-Position: refs/heads/master@{#406230}

Powered by Google App Engine
This is Rietveld 408576698